refactor: bank transaction counts #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
refactor/bank-counts
branch
4 times, most recently
from
dce1a4f to
621a7a1
Compare
jstarry
force-pushed
the
refactor/bank-counts
branch
from
621a7a1 to
1141ded
Compare
apfitzge
previously approved these changes
Aug 2, 2024
| // All transactions that were executed but then failed record because the | ||
| // slot ended | ||
| pub failed_commit_count: usize, | ||
| // Total transaction counts tracked for reporting `LeaderSlotMetrics`. See |
There was a problem hiding this comment.
consistent with other comments so fine to leave as is, but why would all the comments on theese fields not be doc-comments?
| @@ -60,6 +50,48 @@ pub(crate) struct ProcessTransactionsSummary { | |||
| pub max_prioritization_fees: u64, | |||
| } | |||
|
|
|||
| #[derive(Debug, Default, PartialEq)] | |||
| pub struct ProcessTransactionsCounts { | |||
| // Total number of transactions that were passed as candidates for execution | |||
apfitzge
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hard to follow how transaction counts are used throughout the runtime
Summary of Changes
ExecuteAndCommitTransactionsCountsandProcessTransactionsCountsu64fromusizefor a number of countsFixes #