use solana-pubkey instead of solana-sdk in stake-program (#4327)

* use solana-pubkey instead of solana-sdk in stake-program

* remove redundant dep from dev deps (already in main deps)

programs/stake/Cargo.toml

@@ -16,6 +16,7 @@ solana-config-program = { workspace = true }
 solana-feature-set = { workspace = true }
 solana-log-collector = { workspace = true }
 solana-program-runtime = { workspace = true }
+solana-pubkey = { workspace = true }
 solana-sdk = { workspace = true }
 solana-type-overrides = { workspace = true }
 solana-vote-program = { workspace = true }

programs/stake/benches/stake.rs

@@ -3,11 +3,11 @@ use {
     criterion::{black_box, criterion_group, criterion_main, Criterion},
     solana_feature_set::FeatureSet,
     solana_program_runtime::invoke_context::mock_process_instruction,
+    solana_pubkey::Pubkey,
     solana_sdk::{
         account::{create_account_shared_data_for_test, AccountSharedData, WritableAccount},
         clock::{Clock, Epoch},
         instruction::AccountMeta,
-        pubkey::Pubkey,
         stake::{
             instruction::{
                 self, AuthorizeCheckedWithSeedArgs, AuthorizeWithSeedArgs, LockupArgs,
@@ -48,7 +48,7 @@ impl TestSetup {
             StakeStateV2::size_of(),
             &solana_stake_program::id(),
         );
-        let stake_address = solana_sdk::pubkey::Pubkey::new_unique();
+        let stake_address = solana_pubkey::Pubkey::new_unique();
         Self {
             // some stake instructions are behind feature gate, enable all
             // feature gates to bench all instructions

programs/stake/src/points.rs

@@ -2,10 +2,10 @@
 //! Used by `solana-runtime`.
 
 use {
+    solana_pubkey::Pubkey,
     solana_sdk::{
         clock::Epoch,
         instruction::InstructionError,
-        pubkey::Pubkey,
         stake::state::{Delegation, Stake, StakeStateV2},
         stake_history::StakeHistory,
     },

programs/stake/src/rewards.rs

@@ -231,7 +231,8 @@ mod tests {
     use {
         super::*,
         crate::{points::null_tracer, stake_state::new_stake},
-        solana_sdk::{native_token, pubkey::Pubkey},
+        solana_pubkey::Pubkey,
+        solana_sdk::native_token,
         test_case::test_case,
     };
 

programs/stake/src/stake_state.rs

@@ -12,12 +12,12 @@ use {
     solana_feature_set::FeatureSet,
     solana_log_collector::ic_msg,
     solana_program_runtime::invoke_context::InvokeContext,
+    solana_pubkey::Pubkey,
     solana_sdk::{
         account::{AccountSharedData, ReadableAccount},
         account_utils::StateMut,
         clock::{Clock, Epoch},
         instruction::{checked_add, InstructionError},
-        pubkey::Pubkey,
         rent::Rent,
         stake::{
             instruction::{LockupArgs, StakeError},
@@ -1448,10 +1448,10 @@ mod tests {
         super::*,
         proptest::prelude::*,
         solana_program_runtime::with_mock_invoke_context,
+        solana_pubkey::Pubkey,
         solana_sdk::{
             account::{create_account_shared_data_for_test, AccountSharedData},
             epoch_schedule::EpochSchedule,
-            pubkey::Pubkey,
             stake::state::warmup_cooldown_rate,
             sysvar::{epoch_schedule, SysvarId},
         },
@@ -1460,7 +1460,7 @@ mod tests {
 
     #[test]
     fn test_authorized_authorize() {
-        let staker = solana_sdk::pubkey::new_rand();
+        let staker = solana_pubkey::new_rand();
         let mut authorized = Authorized::auto(&staker);
         let mut signers = HashSet::new();
         assert_eq!(
@@ -1476,9 +1476,9 @@ mod tests {
 
     #[test]
     fn test_authorized_authorize_with_custodian() {
-        let staker = solana_sdk::pubkey::new_rand();
-        let custodian = solana_sdk::pubkey::new_rand();
-        let invalid_custodian = solana_sdk::pubkey::new_rand();
+        let staker = solana_pubkey::new_rand();
+        let custodian = solana_pubkey::new_rand();
+        let invalid_custodian = solana_pubkey::new_rand();
         let mut authorized = Authorized::auto(&staker);
         let mut signers = HashSet::new();
         signers.insert(staker);
@@ -2174,7 +2174,7 @@ mod tests {
 
     #[test]
     fn test_lockup_is_expired() {
-        let custodian = solana_sdk::pubkey::new_rand();
+        let custodian = solana_pubkey::new_rand();
         let lockup = Lockup {
             epoch: 1,
             unix_timestamp: 1,