plugins/rink: Let the user disable rink connecting to the internet #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internet for initialization
|
I do not know if this fits in the context of this PR, but how about caching the json file? I know currency conversion changes over time but having it cached for a day or two is probably no big deal and would also speed up init + you do not loose currency conversion. I may open another PR if this ever gets merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration to the rink plugins so that users can disable pulling current currency conversion upon plugin startup.
This stops the rink plugin from connecting to the internet upon startup, as a result the plugin initializes much faster.
A downside is that rink no longer offers currency conversions.
The feature is opt-in, nothing should change as long as the user doesn't specifically disable the pulling of currencies for rink.