feat: Allow user desktop overrides to hide applications from system level desktop files #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides applications which have both a system level desktop file and a user level desktop file where the user level desktop file sets either the `NoDisplay` or `Hidden` entries to `true`. This allows users to remove application entries without editing system level desktop files. Also add support for the `Hidden` desktop entry alongside `NoDisplay`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I noticed that in the application plugin there isn't a way to ignore applications whose desktop entries live in system directories gracefully as changes to these entries get overwritten when packages update.
Normally a user level desktop entry would be the solution but with the way they are currently handled by
anyrun, usingNoDisplayin the user level desktop entry simply treats the user entry as if it did not exist without hiding the system level entry. TheHiddenattribute which more closely maps to this usecase is also not supported right now in any kind of entry.This PR adds support for
Hiddenin general and allows users to hide applications defined by system.desktopfiles by adding a user level.desktopfile with eitherNoDisplayorHiddenset totrue.This does technically change existing behavior but I think the amount of adversely impacted users would be minimal as anyone who overrides the system level entries with an entry that hides an application probably would prefer this behavior. I considered adding a new configuration flag for allowing this new behavior but supporting this would complicate some of the scrubber code.
Let me know what you think!