Lint fixes

anwolosz · Aug 31, 2024 · a163dc4 · a163dc4
1 parent c7da201
commit a163dc4
Show file tree

Hide file tree

Showing 10 changed files with 68 additions and 69 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -7,9 +7,12 @@ module.exports = {
     'plugin:vue/vue3-essential',
     'eslint:recommended',
     '@vue/eslint-config-typescript',
-    '@vue/eslint-config-prettier/skip-formatting'
+    '@vue/eslint-config-prettier/skip-formatting',
   ],
   parserOptions: {
     ecmaVersion: 'latest'
-  }
+  },
+  rules: {
+    'vue/multi-word-component-names': 'off',
+  },
 }
diff --git a/src/App.vue b/src/App.vue
@@ -1,9 +1,6 @@
 <script lang="ts">
-import { RouterView } from 'vue-router'
 import Footer from './components/Footer.vue'
 import Header from './components/Header.vue'
-import { Tooltip } from 'bootstrap'
-
 
 export default {
   components: {

diff --git a/src/components/FunctionButtons.vue b/src/components/FunctionButtons.vue
@@ -17,7 +17,7 @@ export default {
         }
     },
     methods: {
-        copyShareLink(id: string) {
+        copyShareLink() {
             console.log(this.$router);
 
             navigator.clipboard.writeText(window.location.origin + this.$route.path);
@@ -26,8 +26,8 @@ export default {
                 this.isShareCopied = false;
             }, 1500);
         },
-        copyIdLink(id: string) {
-            navigator.clipboard.writeText(window.location.origin + "/" + this.synopsisStore.currentLanguage + "/" + this.synopsisStore.currentTranslation + "#" + id);
+        copyIdLink() {
+            navigator.clipboard.writeText(window.location.origin + "/" + this.synopsisStore.currentLanguage + "/" + this.synopsisStore.currentTranslation + "#" + this.id);
             this.isIdCopied = true
             setTimeout(() => {
                 this.isIdCopied = false;
@@ -54,11 +54,11 @@ export default {
             <i class="bi bi-arrow-down-left-square fs-6"></i>
         </button>
     </router-link>
-    <button v-if="$route.name === 'synopsis'" @click="copyIdLink(id)" type="button"
+    <button v-if="$route.name === 'synopsis'" @click="copyIdLink()" type="button"
         class=" float-right btn btn-light btn-sm ms-1 mb-1" :title="synopsisStore.currentDictionary.tooltips.location">
         <i class="bi fs-6" :class="{ 'bi-link-45deg': !isIdCopied, 'bi-check': isIdCopied }"></i>
     </button>
-    <button v-if="$route.name === 'section'" @click="copyShareLink(id)" type="button"
+    <button v-if="$route.name === 'section'" @click="copyShareLink()" type="button"
         class="float-right  btn btn-light btn-sm ms-1 mb-1" :title="synopsisStore.currentDictionary.tooltips.share">
         <i class="bi fs-6" :class="{ 'bi-link-45deg': !isShareCopied, 'bi-check': isShareCopied }"></i>
     </button>

diff --git a/src/components/Header.vue b/src/components/Header.vue
@@ -77,7 +77,7 @@ export default {
                             <i class="bi bi-globe2 fs-5 align-middle"></i>
                         </button>
                         <ul class="dropdown-menu dropdown-menu-end">
-                            <template v-for="synopsis in synopsisStore.synopses">
+                            <template v-for="synopsis in synopsisStore.synopses" :key="synopsis.language">
                                 <li> <a @click="synopsis.language !== synopsisStore.currentLanguage ? synopsisStore.changeLanguage(synopsis.language) : null"
                                         class="dropdown-item hoverable text-black"
                                         :class="synopsis.language === synopsisStore.currentLanguage ? 'bg-dark-subtle' : ''">
@@ -91,7 +91,7 @@ export default {
                             <i class="bi bi-book fs-5 align-middle"></i>
                         </button>
                         <ul class="dropdown-menu dropdown-menu-end">
-                            <template v-for="synopsis in synopsisStore.synopses">
+                            <template v-for="synopsis in synopsisStore.synopses" :key="synopsis.translation">
                                 <li> <a @click="synopsis.translation !== synopsisStore.currentTranslation ? synopsisStore.changeTranslation(synopsis.translation) : null"
                                         class="dropdown-item hoverable text-black"
                                         :class="synopsis.translation === synopsisStore.currentTranslation ? 'bg-dark-subtle' : ''">

diff --git a/src/components/IndexRecord.vue b/src/components/IndexRecord.vue
@@ -25,53 +25,55 @@ export default {
             {{ chapterName }}
         </h2>
     </div>
-    <template v-for="subchapter in subchapters" class="row">
-        <h3 class="text-center fs-4">{{ subchapter.subchapter_name }}</h3>
-        <div class="table-responsive">
-            <table class="table bg-dark table-sm table-striped table-bordered">
-                <thead>
-                    <tr>
-                        <th class="fw-normal text-nowrap" scope="col"># ( <i
-                                class="bi bi-arrow-down-left-square fs-6"></i> )</th>
-                        <th class="fw-normal text-nowrap" scope="col">{{ synopsisStore.currentDictionary.index.title }} ( <i
-                                class="bi bi-arrow-up-right-square fs-6"></i> )</th>
-                        <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.mt }}
-                        </th>
-                        <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.mk }}
-                        </th>
-                        <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.lk }}
-                        </th>
-                        <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.jn }}
-                        </th>
-                    </tr>
-                </thead>
-                <tbody class="table-group-divider">
-                    <tr v-for="section in subchapter.sections">
-                        <th class="col-lg-1 align-middle text-nowrap" scope="row">
-                            <router-link :to="{ name: 'synopsis', hash: '#' + section.id }">
-                                {{ section.id }}
-                            </router-link>
-                        </th>
-                        <td class="col-lg-7 align-middle text-nowrap">
-                            <router-link :to="{ name: 'section', params: { id: section.id } }">
-                                {{ section.section_name }}
-                            </router-link>
-                        </td>
-                        <td class="col-lg-1 align-middle">
-                            <IndexCitation :citations="section.mt" />
-                        </td>
-                        <td class="col-lg-1 align-middle">
-                            <IndexCitation :citations="section.mk" />
-                        </td>
-                        <td class="col-lg-1 align-middle">
-                            <IndexCitation :citations="section.lk" />
-                        </td>
-                        <td class="col-lg-1 align-middle">
-                            <IndexCitation :citations="section.jn" />
-                        </td>
-                    </tr>
-                </tbody>
-            </table>
+    <template v-for="subchapter in subchapters">
+        <div clas="row">
+            <h3 class="text-center fs-4">{{ subchapter.subchapter_name }}</h3>
+            <div class="table-responsive">
+                <table class="table bg-dark table-sm table-striped table-bordered">
+                    <thead>
+                        <tr>
+                            <th class="fw-normal text-nowrap" scope="col"># ( <i
+                                    class="bi bi-arrow-down-left-square fs-6"></i> )</th>
+                            <th class="fw-normal text-nowrap" scope="col">{{ synopsisStore.currentDictionary.index.title }} ( <i
+                                    class="bi bi-arrow-up-right-square fs-6"></i> )</th>
+                            <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.mt }}
+                            </th>
+                            <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.mk }}
+                            </th>
+                            <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.lk }}
+                            </th>
+                            <th class="text-center fw-normal" scope="col">{{ synopsisStore.currentDictionary.evangelists.jn }}
+                            </th>
+                        </tr>
+                    </thead>
+                    <tbody class="table-group-divider">
+                        <tr v-for="section in subchapter.sections">
+                            <th class="col-lg-1 align-middle text-nowrap" scope="row">
+                                <router-link :to="{ name: 'synopsis', hash: '#' + section.id }">
+                                    {{ section.id }}
+                                </router-link>
+                            </th>
+                            <td class="col-lg-7 align-middle text-nowrap">
+                                <router-link :to="{ name: 'section', params: { id: section.id } }">
+                                    {{ section.section_name }}
+                                </router-link>
+                            </td>
+                            <td class="col-lg-1 align-middle">
+                                <IndexCitation :citations="section.mt" />
+                            </td>
+                            <td class="col-lg-1 align-middle">
+                                <IndexCitation :citations="section.mk" />
+                            </td>
+                            <td class="col-lg-1 align-middle">
+                                <IndexCitation :citations="section.lk" />
+                            </td>
+                            <td class="col-lg-1 align-middle">
+                                <IndexCitation :citations="section.jn" />
+                            </td>
+                        </tr>
+                    </tbody>
+                </table>
+            </div>
         </div>
     </template>
 </template>
diff --git a/src/components/Section.vue b/src/components/Section.vue
@@ -1,7 +1,6 @@
 <script lang="ts">
 import Citation from '@/components/Citation.vue'
 import FunctionButtons from '@/components/FunctionButtons.vue'
-import type { SectionScheme } from '@/interfaces/synopsisInterface'
 import { useSynopsisStore } from "@/stores/SynopsisStore"
 
 export default {
@@ -54,7 +53,7 @@ export default {
         </div>
     </div>
 
-    <template v-for="index in section.mt.length">
+    <template v-for="index in section.mt.length" :key="index">
         <div class="row content mx-3">
             <div class="col-lg-3 col-md-12 pb-3">
                 <Citation v-if="section.mt[index - 1] !== null" :citation="section.mt[index - 1]" evangelist="mt"

diff --git a/src/components/Subchapter.vue b/src/components/Subchapter.vue
@@ -29,7 +29,7 @@ export default {
         </h4>
     </div>
 
-    <Section v-for="section in subchapter.sections" :id="section.id"/>
+    <Section v-for="section in subchapter.sections" :id="section.id" :key="section.id"/>
 
 
 </template>
diff --git a/src/router/index.ts b/src/router/index.ts
@@ -7,7 +7,6 @@ import ContactView from '@/views/ContactView.vue'
 import NotFoundView from '@/views/NotFoundView.vue'
 import Section from '@/components/Section.vue'
 import { useSynopsisStore } from "@/stores/SynopsisStore"
-import { TypePredicateKind } from 'typescript'
 
 const router = createRouter({
   history: createWebHistory(import.meta.env.BASE_URL),
@@ -49,7 +48,7 @@ const router = createRouter({
       component: NotFoundView
     },
   ],
-  scrollBehavior(to, from, savedPosition) {
+  scrollBehavior(to) {
     if (to.hash) {
       return {
         el: to.hash,
@@ -61,7 +60,7 @@ const router = createRouter({
   },
 })
 
-router.beforeEach((to, from) => {
+router.beforeEach((to) => {
   useSynopsisStore().setupLanguage(to.params.language)
   useSynopsisStore().setupTranslation(to.params.translation)
 })

diff --git a/src/views/IndexView.vue b/src/views/IndexView.vue
@@ -34,7 +34,7 @@ export default {
 
     <IndexRecord :chapter-name="synopsisStore.currentSynopsis.chapters[0].chapter_name"
       :subchapters="synopsisStore.currentSynopsis.chapters[0].subchapters" />
-    <template v-for="chapterIndex in synopsisStore.currentSynopsis.chapters.length - 1">
+    <template v-for="chapterIndex in synopsisStore.currentSynopsis.chapters.length - 1" :key="chapterIndex">
       <IndexRecord v-if="visibleIndex >= chapterIndex"
         :chapter-name="synopsisStore.currentSynopsis.chapters[chapterIndex].chapter_name"
         :subchapters="synopsisStore.currentSynopsis.chapters[chapterIndex].subchapters" />

diff --git a/src/views/SynopsisView.vue b/src/views/SynopsisView.vue
@@ -1,6 +1,5 @@
 <script lang="ts">
 import Chapter from '@/components/Chapter.vue'
-import type { ChapterScheme } from '@/interfaces/synopsisInterface';
 import { useSynopsisStore } from "@/stores/SynopsisStore"
 
 
@@ -88,8 +87,8 @@ export default {
       </div>
     </div>
 
-    <template v-show="!showScroller" v-for="chapterIndex in synopsisStore.currentSynopsis.chapters.length">
-      <Chapter v-if="visibleIndex >= chapterIndex - 1"
+    <template v-for="chapterIndex in synopsisStore.currentSynopsis.chapters.length">
+      <Chapter v-show="!showScroller" v-if="visibleIndex >= chapterIndex - 1"
         :chapter="synopsisStore.currentSynopsis.chapters[chapterIndex - 1]" />
     </template>