Add Windows support for toolbox image #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add Windows images to the antrea/toolbox manifest (for both the 1809 and ltsc2022 Windows nanoserver versions). The Windows image is based directly on K8s pause image. It includes wincat, pause, and of course everything included by default in the nanoserver image (such as ping). In the future, we may want to install additional utilities in the Windows image. Because we share the same versioning between Linux and Windows, the toolbox version is bumped up to 1.3. Fixes antrea-io#26 Signed-off-by: Antonin Bas <[email protected]>
tnqn
approved these changes
Jan 30, 2024
| echo "docker_tag=${version}-${rev}" >> $GITHUB_OUTPUT | ||
| outputs: | ||
| version: ${{ steps.get-outputs.outputs.version }} | ||
| rev: ${{ steps.get-outputs.outputs.rev }} |
There was a problem hiding this comment.
yes, it's true but I didn't feel the need to remove it
Comment on lines
+26
to
+27
| # We do not add any tools to the image at the moment. | ||
| # The image comes with pause + wincat + anything included by default in the nanoserver base image. |
There was a problem hiding this comment.
Yes, I checked. It's included by default in the nanoserver image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add Windows images to the antrea/toolbox manifest (for both the 1809 and ltsc2022 Windows nanoserver versions).
The Windows image is based directly on K8s pause image. It includes wincat, pause, and of course everything included by default in the nanoserver image (such as ping).
In the future, we may want to install additional utilities in the Windows image.
Because we share the same versioning between Linux and Windows, the toolbox version is bumped up to 1.3.
Fixes #26