Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows Conformance failure by updating time synchronization script #6906

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Windows Conformance failure by updating time synchronization script #6906

wants to merge 1 commit into from

Conversation

XinShuYang
Copy link
Contributor

fixes #6892

@XinShuYang
Copy link
Contributor Author

/test-windows-all

@XinShuYang XinShuYang marked this pull request as ready for review January 9, 2025 07:10
@XinShuYang
Copy link
Contributor Author

/test-windows-all

tnqn
tnqn approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

@luolanzone luolanzone added the area/OS/windows Issues or PRs related to the Windows operating system. label Jan 13, 2025
@XinShuYang
Copy link
Contributor Author

@tnqn Thanks for the review, Windows CI passed. The e2e test failure is caused by different issue and will be fixed in #6891, so we can ignore it in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

Assignees
No one assigned
Labels
area/OS/windows Issues or PRs related to the Windows operating system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows conformance test failed with case "Service endpoints latency [It] should not be very high"
3 participants
@XinShuYang @tnqn @luolanzone