Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate ovsdb client library #6176

Closed

Conversation

aroradaman
Copy link
Contributor

@aroradaman aroradaman commented Mar 31, 2024

Migrate from github.com/TomCodeLV/OVSDB-golang-lib/pkg/ovsdb to github.com/ovn-org/libovsdb for ovsdb interactions.

fixes: #5635

Migrate from github.com/TomCodeLV/OVSDB-golang-lib/pkg/ovsdb to
github.com/ovn-org/libovsdb for ovsdb interactions.

Signed-off-by: Daman Arora <[email protected]>
@aroradaman
Copy link
Contributor Author

Tried using the High-level API/ORM from github.com/ovn-org/libovsdb, and will explore the low-level API next and compare both.


// Port defines an object in Port table
type Port struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the current model and only include the fields that we actually need?
Some fields may be required but I am pretty sure not all fields are required.
When I was working antrea-io/ofnet#76, I only had a subset of fields for the bridge table.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I just used the schema generated by model-gen to experiment with the flow. Will also configure monitor options for selected fields only rather than the complete table.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2024
@github-actions github-actions bot closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace github.com/TomCodeLV/OVSDB-golang-lib with github.com/ovn-org/libovsdb
2 participants