Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Abbreviation #88

Merged
merged 4 commits into from
Jan 7, 2024
Merged

Feat: Abbreviation #88

merged 4 commits into from
Jan 7, 2024

Conversation

Trkzi-Omar
Copy link
Contributor

No description provided.

@Trkzi-Omar
Copy link
Contributor Author

@antonkomarev, I think that this will do, but feel free to edit it as you see fits.

@antonkomarev antonkomarev self-assigned this Jan 7, 2024
@antonkomarev
Copy link
Owner

You pushed changes to master, it's not great when you are contributing. Don't forget to create separate branches. I've made changes in your master branch, but after merging this PR you wouldn't be able to proceed make changes there, because your master would be conflicting with current master after squash.

@antonkomarev antonkomarev merged commit 1c1f245 into antonkomarev:master Jan 7, 2024
10 checks passed
@antonkomarev
Copy link
Owner

@Trkzi-Omar thanks for contribution! Your code is commited, but not pushed to production yet. I'll try to make it with next week, when some more critical changes will be completed.

@orhun
Copy link

orhun commented Jan 7, 2024

This is a great feature, thanks for adding it @Trkzi-Omar!

@antonkomarev can you ping here once you deploy this please? I would like to add it to my profile.

@antonkomarev
Copy link
Owner

@orhun sure, I'll write about it here

@antonkomarev
Copy link
Owner

@orhun @Trkzi-Omar released. You can add &abbreviated=true to the URL

@orhun
Copy link

orhun commented Jan 8, 2024

thanks, just added to my profile!

@antonkomarev
Copy link
Owner

thanks, just added to my profile!

Looks good!

@Trkzi-Omar
Copy link
Contributor Author

This is a great feature, thanks for adding it @Trkzi-Omar!

@antonkomarev can you ping here once you deploy this please? I would like to add it to my profile.

I am glad you found it interesting. Happy to contribute to OSS 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants