Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ cleanup: replace omit.js & remove some duplicate util #8965

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Jan 9, 2025

background: #8931

在 8931 中讨论到用 es-toolkit 替换 lodash-es, 全文搜索了一下发现没多少地方调用,所以将部分方法进行移除

  1. rc-util/lib/omit 替换 omit.js 依赖 - 718fa12
  2. 部分 lodash/mergerc-util/lib/utils/set 代替 - b4752e6
  3. 参考 es-toolkit 的 toNumber 实现,替换掉 lodash/toNumber - 24fa2d1

以上~

Copy link

github-actions bot commented Jan 9, 2025

😭 Deploy PR Preview failed.

Copy link

pkg-pr-new bot commented Jan 9, 2025

@ant-design/pro-card

npm i https://pkg.pr.new/@ant-design/pro-card@8965

@ant-design/pro-components

npm i https://pkg.pr.new/@ant-design/pro-components@8965

@ant-design/pro-descriptions

npm i https://pkg.pr.new/@ant-design/pro-descriptions@8965

@ant-design/pro-field

npm i https://pkg.pr.new/@ant-design/pro-field@8965

@ant-design/pro-form

npm i https://pkg.pr.new/@ant-design/pro-form@8965

@ant-design/pro-layout

npm i https://pkg.pr.new/@ant-design/pro-layout@8965

@ant-design/pro-list

npm i https://pkg.pr.new/@ant-design/pro-list@8965

@ant-design/pro-skeleton

npm i https://pkg.pr.new/@ant-design/pro-skeleton@8965

@ant-design/pro-provider

npm i https://pkg.pr.new/@ant-design/pro-provider@8965

@ant-design/pro-table

npm i https://pkg.pr.new/@ant-design/pro-table@8965

@ant-design/pro-utils

npm i https://pkg.pr.new/@ant-design/pro-utils@8965

commit: 355d122

@Wxh16144
Copy link
Member Author

这覆盖测试本地好好的,怎么 CI 一跑就挂了?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant