Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing last line when kube err #1216

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

matoval
Copy link
Collaborator

@matoval matoval commented Nov 20, 2024

This PR shows an issue reading last line when kube api returns an error because the error string doesn't end in a new line. The last line includes eof and never gets read.

I discovered this issue when getting failed to create fsnotify watcher: too many open files error in kube logs but receptor never got that error string.

We should look at refactoring way this file gets logs from kube api.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 40.49%. Comparing base (9243ccb) to head (38bbf4e).
Report is 3 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/kubernetes.go 0.00% 9 Missing ⚠️
@@            Coverage Diff             @@
##            devel    #1216      +/-   ##
==========================================
+ Coverage   39.93%   40.49%   +0.56%     
==========================================
  Files          45       48       +3     
  Lines        9266     9854     +588     
==========================================
+ Hits         3700     3990     +290     
- Misses       5289     5588     +299     
+ Partials      277      276       -1     
Files with missing lines Coverage Δ
pkg/workceptor/kubernetes.go 21.41% <0.00%> (-0.14%) ⬇️

... and 6 files with indirect coverage changes

Components Coverage Δ
Go 39.93% <0.00%> (+<0.01%) ⬆️
Receptorctl 49.31% <ø> (∅)

Copy link

sonarqubecloud bot commented Dec 3, 2024

@matoval matoval marked this pull request as ready for review December 3, 2024 16:51
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 6b07743 into ansible:devel Dec 4, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants