Fix ansible#4142 - config file in proj dir (second attempt)

[erichoog]

This resolves the issue raised in Issue #4142 where Molecule does not find the config.yml file the project directory {project_dir}/.config/molecule/config.yml but does find it in the home directory.

I ran tests by isolating the 2 functions being called when LOCAL_CONFIG variable is defined and verifying that the config file is found when in the project dir. If there is no {project_dir}/.config/molecule/config.yml then it looks in ~/.config/molecule/config.yml and finds the config file.

I have not been able to test the full project with the tox command as my environment is having issues. The tox tests are not completing even on a freshly cloned repo.

The code in the find_vcs_root function could likely be modified more as it does not appear to be called elsewhere and it searches for ".git", ".hg", ".svn" dirs as well for what appears to be no reason as far as I can tell since it is only used for locating .config/molecule/config.yml

Let me know if anything can be improved upon here with my delivery of this as it is my first PR with the project.

Fixes: #4142

[ssbarnea]

Missing tests and documentation, the .config folder is not realy a vcs.

[erichoog]

Missing tests and documentation, the .config folder is not realy a vcs.

I'll work on adding the tests hopefully this week.

For the .config not being a vcs, I'll take a look at the code again and see if this should be implemented elsewhere or in a new function.

[erichoog]

Missing tests and documentation, the .config folder is not realy a vcs.

@ssbarnea After reviewing this further, I have determined that the issue I was seeing was because I was not using vcs like git in my test project dir. Therefore, since there was no .git directory in my project directory the find_vcs_root function was not finding my .config/molecule/config.yml file.

I am now wondering if it would just make more sense to update the documentation to make it more clear that the .config/molecule/config.yml would only be found in the project directory if version control is being used?

Or would it still be good to pursue modifying the code to allow the .config/molecule/config.yml to be found in the project dir when source control is not being used?