Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a simple test for columns and sheets in the data file. #37

Closed

Conversation

ShaiahWren
Copy link
Contributor

@ShaiahWren ShaiahWren commented Jan 14, 2025

[AAP-38383]

This pr adds a test in metrics-utility/test/shipped_data/test_RENEWAL_GUIDANCE.py
It opens the xlsx file and verifies spreadsheet tabs (sheet names) and columns for each.

Testing

  • In root dir metrics-utility create virtual environment 'venv' and activate it:
    python -m venv venv
    source venv/bin/activate
  • install pytest (different for each OS)
  • run pytest metrics_utility/test/shipped_data/test_RENEWAL_GUIDANCE.py

Expected Results

All tests should pass

@MilanPospisil
Copy link
Contributor

Its good start! However, there was some miscommunication:

This test should test CCSPv2 report (as the name of your branch suggests :-) and as it is described in your issue :-) )

No worries, you learned something and different tests will be similar to each other.

Let this PR to be draft, we will return to it later once we will write Renewal guidance - we are waiting for Martin to prepare testing DB.

Please unlink this PR from CCSPv2 issue and create new PR that will test CCSPv2 report properly. We will have call today about it, so you are on the same page :-)

@MilanPospisil MilanPospisil marked this pull request as draft January 17, 2025 12:41
@ShaiahWren ShaiahWren closed this Jan 17, 2025
@ShaiahWren
Copy link
Contributor Author

Closing and replacing with #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants