Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [AAP-34609] - change created_by/modified_by into object type in openapi.json #1189

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

hsong-rh
Copy link
Contributor

Change created_by and modified_by to the type of object in the auto-generated schema file.
It will solve the failures in https://github.com/ansible/eda-qa/pull/447

https://issues.redhat.com/browse/AAP-34609

@hsong-rh hsong-rh requested a review from a team as a code owner January 15, 2025 17:40
@hsong-rh hsong-rh force-pushed the fix_openapi_types branch 3 times, most recently from b6ae8be to c3cfc67 Compare January 15, 2025 17:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.34%. Comparing base (1d12765) to head (d79f8a4).

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   93.33%   93.34%   +0.01%     
==========================================
  Files         260      261       +1     
  Lines       14848    14875      +27     
==========================================
+ Hits        13858    13885      +27     
  Misses        990      990              
Flag Coverage Δ
unit-int-tests-3.11 93.27% <100.00%> (+0.01%) ⬆️
unit-int-tests-3.12 93.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/api/serializers/activation.py 95.87% <100.00%> (+0.03%) ⬆️
...rc/aap_eda/api/serializers/decision_environment.py 100.00% <100.00%> (ø)
src/aap_eda/api/serializers/eda_credential.py 98.96% <100.00%> (+0.03%) ⬆️
src/aap_eda/api/serializers/event_stream.py 96.29% <100.00%> (+0.21%) ⬆️
src/aap_eda/api/serializers/fields/basic_user.py 100.00% <100.00%> (ø)
src/aap_eda/api/serializers/project.py 93.13% <100.00%> (+0.50%) ⬆️

Alex-Izquierdo
Alex-Izquierdo previously approved these changes Jan 15, 2025
src/aap_eda/api/serializers/fields/basic_user.py Outdated Show resolved Hide resolved
bzwei
bzwei previously approved these changes Jan 15, 2025
@hsong-rh hsong-rh dismissed stale reviews from bzwei and Alex-Izquierdo via f84091e January 15, 2025 19:22
@hsong-rh hsong-rh merged commit 12ec3eb into ansible:main Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants