fix: remove event_stream_type from the payload when creating/updating…

… event streams (#1092)
ansible · Oct 10, 2024 · d83f540 · d83f540
1 parent ee2bc4f
commit d83f540
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 57 deletions.
diff --git a/src/aap_eda/api/serializers/event_stream.py b/src/aap_eda/api/serializers/event_stream.py
@@ -63,7 +63,6 @@ class Meta:
             "additional_data_headers",
             "eda_credential_id",
             "organization_id",
-            "event_stream_type",
         ]
 
 

diff --git a/tests/integration/api/test_event_stream.py b/tests/integration/api/test_event_stream.py
@@ -147,34 +147,6 @@ def test_update_event_stream(
         )
 
 
-@pytest.mark.django_db
-def test_update_event_stream_with_mismatched_type(
-    admin_client: APIClient,
-    default_hmac_credential: models.EdaCredential,
-    default_organization: models.Organization,
-    default_event_stream: models.EventStream,
-):
-    invalid_event_stream_type = "mismatched_type"
-    data_in = {
-        "name": "new_test_event_stream",
-        "event_stream_type": invalid_event_stream_type,
-    }
-    with override_settings(
-        EVENT_STREAM_BASE_URL="https://www.example.com/",
-    ):
-        response = admin_client.patch(
-            f"{api_url_v1}/event-streams/{default_event_stream.id}/",
-            data=data_in,
-        )
-        assert response.status_code == status.HTTP_400_BAD_REQUEST
-        assert (
-            f"The input event stream type {invalid_event_stream_type} does "
-            "not match with the credential type "
-            f"{default_hmac_credential.credential_type.kind}"
-            in response.data["non_field_errors"]
-        )
-
-
 @pytest.mark.django_db
 def test_create_event_stream_without_credentials(
     admin_client: APIClient, default_organization: models.Organization
@@ -190,34 +162,6 @@ def test_create_event_stream_without_credentials(
     }
 
 
-@pytest.mark.django_db
-def test_create_event_stream_with_mismatched_types(
-    admin_client: APIClient,
-    default_organization: models.Organization,
-    default_hmac_credential: models.EdaCredential,
-):
-    invalid_event_stream_type = "invalid_type"
-    data_in = {
-        "name": "test_es",
-        "event_stream_type": invalid_event_stream_type,
-        "eda_credential_id": default_hmac_credential.id,
-        "organization_id": default_organization.id,
-    }
-    with override_settings(
-        EVENT_STREAM_BASE_URL="https://www.example.com/",
-    ):
-        response = admin_client.post(
-            f"{api_url_v1}/event-streams/", data=data_in
-        )
-        assert response.status_code == status.HTTP_400_BAD_REQUEST
-        assert (
-            f"The input event stream type {invalid_event_stream_type} does "
-            "not match with the credential type "
-            f"{default_hmac_credential.credential_type.kind}"
-            in response.data["non_field_errors"]
-        )
-
-
 @pytest.mark.django_db
 def test_delete_event_stream(
     admin_client: APIClient,