Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature Flags: Phase 2 (Add Runtime Toggle) #680

Draft
wants to merge 8 commits into
base: devel
Choose a base branch
from

Conversation

zkayyali812
Copy link

AAP-37243 Runtime Toggle of Feature Flags

This PR builds off of #650, this draft can be closed in favor of that PR if the team would like as well.

Description

  • What is being changed?
    Updates feature flag module to enable runtime toggle. Allowing a centralized location to manage feature flags for each component to leverage.
  • Why is this change needed?
    To simplify feature flag management, and eventually allow management/toggling from unified UI.
  • How does this change address the issue?
    By providing a common API to get/set feature flag state, along with a common way of defining feature flags for each component.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Prerequisites

Steps to Test

Expected Results

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Screenshots/Logs

Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@john-westcott-iv john-westcott-iv changed the title Feature Flags: Phase 2 (Add Runtime Toggle) [WIP] Feature Flags: Phase 2 (Add Runtime Toggle) Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants