Set feature flag base on setting

[TheRealHaoLiu]

SUMMARY

Set value of feature flag base on local setting

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• API

AWX VERSION

ADDITIONAL INFORMATION

[AlanCoding]

Context:

This would address my comments on #15799

[AlanCoding]

More context, people have talked this out at some point or another:

#15702 would add dynaconf. The key feature of that is getting settings from environment variables. This includes nested variables, like FLAGS__FEATURE_INDIRECT_NODE_COUNTING_ENABLED__0__value=true. Some syntax like that would turn on indirect node counting.

But that's unlikely to be ready very soon, and we want to unblock the work that this would allow.

This will still probably change a little bit what that PR is doing so I want to get everyone in the loop and then we can go ahead with this merge.

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.28%. Comparing base (a74e730) to head (d7d7a8e).
Report is 1 commits behind head on devel.

✅ All tests successful. No failed tests found.

[pb82]

thanks @TheRealHaoLiu , this implements this proposal: https://handbook.eng.ansible.com/proposals/0068-Feature-flags-configuration-at-install-time

[AlanCoding]

This topic keeps getting deeper

Apparently, the FLAGS__FEATURE_INDIRECT_NODE_COUNTING_ENABLED__0__value syntax is a recent addition - CITATION NEEDED

dynaconf/dynaconf#1001

That appears to maybe be when this was added. Merged Apr 19, 2024. Check commit, not in any tags. Waiting for the next major release apparently.

@TheRealHaoLiu your PR now actually makes sense. Without this piece of the puzzle, I have to admit this appeared to be nonsense. Why not just set the nested value? It seems we have a long way to go before dynaconf will allow an environment variable to do this.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud