feat: remaining schema changes for indirect host audits #15787
Conversation
|
|
||
| name = CharField(max_length=255) | ||
|
|
||
| canonical_facts = JSONField(default=dict) |
There was a problem hiding this comment.
Should there be a uniqueness constraint on canonical_facts? @Ladas
There was a problem hiding this comment.
@AlanCoding hm I think 'unique_together': {('name', 'job')} is good, making managed node name, job_id combination unique.
(I wonder if "name" is enough/good given the table has ManagedNode in it, officially this is managed_node_name, but AWX already uses host_name in many places...)
What the processing code needs to do though, if we'll be getting these records from one job run:
name: "host1", job: "1", canonical_facts: {"serial_number: "XY"}
name: "host1", job: "1", canonical_facts: {"machine_uuid: "XX"}
it needs to merge them into(with the on-conflict clause of the upsert):
name: "host1", job: "1", canonical_facts: {"serial_number: "XY", "machine_uuid: "XX"}
now a case
name: "host1", job: "1", canonical_facts: {"serial_number: "XY", "machine_uuid: "ZZ"}
name: "host1", job: "1", canonical_facts: {"machine_uuid: "XX"}
we can solve with just storing the individual canonical facts/facts as array by default (with the on-conflict clause of the upsert):
name: "host1", job: "1", canonical_facts: {"serial_number: ["XY"], "machine_uuid: ["ZZ","XX"]}
------->
I think I'd prefer this approach, to approach with unique index on canonical facts...(a bit less data to store around) But that it's an alternative solution. We will be still doing deduplication for the reports, there the result is already something like:
name: "host1", canonical_facts: {names:['host1', 'host_2'], "serial_number: ["XY"], "machine_uuid: ["ZZ","XX"]}
There was a problem hiding this comment.
It would be good to cover these cases by tests, no matter which path we'll choose
|
SUMMARY
Remaining schema changes for indirect host audit:
New model & table
IndirectManagedNodeAuditto store audit resultsNew column
event_queries_processedto store whether a job has already been processedISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION