Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put duplicate plugin location in error message #15781

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

AlanCoding
Copy link
Member

SUMMARY

I was trying to adjust some things in our testing suite, and I was getting very frustrated due to this error message, and the lack of actionable information that it gives me.

Before:

E               ValueError: a ManagedCredentialType with namespace=controller is already defined in /awx_devel/awx/main/models/credential.py

You say that the controller credential type is already defined... but why are you telling me this? I don't have prior context, why does it matter that it is already defined? I would hope that it should be defined, yes. That definition sounds like a perfectly good way to define it. Why is this a problem? I see there is a hint that we have a conflicting definition... I know nothing about this other definition.

After:

E               ValueError: a ManagedCredentialType with namespace=controller was defined in awx_plugins.credentials.plugins:controller, but also defined in /awx_devel/awx/main/models/credential.py
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@AlanCoding AlanCoding merged commit c418bc0 into ansible:devel Jan 29, 2025
27 checks passed
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (a19e1ba) to head (76b9fcc).
Report is 15 commits behind head on devel.

✅ All tests successful. No failed tests found.

❌ Your project status has failed because the head coverage (75.23%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants