Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make awx/main/tests/live dramatically faster #15780

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

AlanCoding
Copy link
Member

SUMMARY

I noticed a lot of slowdown running the "live" tests, particularly related to projects which do a lot of syncing and running of jobs. When I cross-referenced against the UI I saw a lot of things hanging out in "pending" status. That's strange... even stranger that they wind up passing.

Turns out, when "pytest" is in sys.argv we just don't send any messages to pg_notify. Well there's you're slowdown! To do anything, the tests were waiting for the once-ever-20-seconds periodic task.

  • before: 5 passed, 5 warnings in 167.92s (0:02:47)
  • after: 1 failed, 4 passed, 5 warnings in 17.58s (think the failure is a local problem)

That 17 seconds is 😚

This is still not implemented in the separate dispatcher library. I still haven't dived into the details, but having this as a dispatcher config-like property is probably the best path forward, so this patch should help make changes in that area as well.

We may still have friction in some other checks, because this is going to move us in the direction of sending messages by default (which will error if not configured right). While this is more risky for development, I consider it less risky for production purposes.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@AlanCoding
Copy link
Member Author

For the dev-env check here

12 passed, 5 warnings in 158.24s (0:02:38)

from another PR #15782

12 passed, 5 warnings in 312.49s (0:05:12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant