-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: set non-zero return code for canceled
status
#15678
base: devel
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
@ryanpetrello @AlanCoding I'm tagging you because you participated in the original implementation (#6081). What do you think of this enhancement? |
Hey @mhassan1, @AlanCoding can probably answer best - I'm no longer an active contributor to AWX. |
Hello @mhassan1, thank you for your contribution! We like the idea of your PR, but would prefer that cancelled return a different code than that of failed or error. Would you be open to modifying that in this PR? |
Quality Gate passedIssues Measures |
@djyasin I've updated the PR to set exit code 2 for the |
Thank you so much! We will review these changes and get back to you soon! |
SUMMARY
This PR adds
canceled
to the list of statuses that causelaunch
commands (with--monitor
or--wait
) to exit non-zero.If a job is canceled, I expect the caller to get a non-zero return code; otherwise, the caller will think that the job completed successful, even though it did not.
This is a follow-up to #6081.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
N/A