Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation tests, replace react-router-hash-link, prevent depdenabot from react-router-dom v7 #5355

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Dec 13, 2024

Closes #5316

crc is not yet compatible with react-router v7, is runtime-compatible with react-router-dom v7, but throws a peer dependency error with @redhat-cloud-services/[email protected].

Pulling out appliable fixes from there.
Updating dependabot config to skip react-router-dom v7.
(and sync the older branches accordingly)

toc links still scroll with react-router 7
reloading after the click was needed before the ui started waiting for the task to finish
but now the ui does wait, and reloads when it is done .. but if the test reloads first, it stops waiting and won't reload when done
@github-actions github-actions bot added backport-4.9 This PR should be backported to stable-4.9 (2.4) backport-4.10 labels Dec 13, 2024
@himdel himdel added dependencies Pull requests that update a dependency file and removed backport-4.9 This PR should be backported to stable-4.9 (2.4) backport-4.10 labels Dec 13, 2024
@himdel himdel merged commit 4d920c5 into ansible:master Dec 13, 2024
12 of 14 checks passed
@himdel himdel deleted the router-no-7 branch December 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant