Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lingui to v5 #5349

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Bump lingui to v5 #5349

merged 5 commits into from
Dec 13, 2024

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Dec 11, 2024

https://lingui.dev/blog/2024/11/28/announcing-lingui-5.0
https://lingui.dev/releases/migration-5

Bump lingui to v5,
switch from babel-plugin-macros to @lingui/babel-plugin-lingui-macro,
drop /macro, add /core, update imports from /macro to go to /core/macro or /react/macro,
add eslint-plugin-lingui, bump eslint & typescript-eslint, fix new warnings, allow updating

Closes #5345
Closes #5366

@github-actions github-actions bot added backport-4.9 This PR should be backported to stable-4.9 (2.4) backport-4.10 labels Dec 11, 2024
@himdel himdel added dependencies Pull requests that update a dependency file and removed backport-4.9 This PR should be backported to stable-4.9 (2.4) backport-4.10 labels Dec 11, 2024
remove lingui macro, split into react/macro and core/macro
remove babel macro, replace with lingui macro plugin
    perl -i -npe 's/@lingui\/macro/@lingui\/core\/macro/' src/**/*.*
    perl -i -npe 's/import { Trans,(.*) from ..lingui.core.macro/import { Trans } from '\''\@lingui\/react\/macro'\''; import {$1 from '\''\@lingui\/core\/macro/' src/**/*.*
    perl -i -npe 's/import { Trans } from ..lingui.core.macro/import { Trans } from '\''\@lingui\/react\/macro/' src/**/*.*
    perl -i -npe 's/; import/;
    import/' src/**/*.*
    npm run prettier
and fix linter warnings, allow dependabot to update these again,
disable `lingui/no-expression-in-message` for now, too many warnings
@himdel himdel merged commit e818c4d into ansible:master Dec 13, 2024
9 of 14 checks passed
@himdel himdel deleted the bump-lingui branch December 13, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant