Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection upload/deprecate - fix permission checks #4015

Merged
merged 17 commits into from
Dec 4, 2023

openHeaderKebab: add comment about the wait

5d882eb
Select commit
Loading
Failed to load commit list.
Merged

Collection upload/deprecate - fix permission checks #4015

openHeaderKebab: add comment about the wait
5d882eb
Select commit
Loading
Failed to load commit list.
Patchback / Backport to stable-4.9 completed Dec 4, 2023 in 17s

Backport to stable-4.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d0ad573 on top of patchback/backports/stable-4.9/d0ad5731a14af5cda547ab5238cdfe1e1aaf4ea1/pr-4015

Details

Backporting merged PR #4015 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible/ansible-hub-ui.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-4.9/d0ad5731a14af5cda547ab5238cdfe1e1aaf4ea1/pr-4015 upstream/stable-4.9
  4. Now, cherry-pick PR #4015 contents into that branch:
    $ git cherry-pick -x d0ad5731a14af5cda547ab5238cdfe1e1aaf4ea1
    If it'll yell at you with something like fatal: Commit d0ad5731a14af5cda547ab5238cdfe1e1aaf4ea1 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x d0ad5731a14af5cda547ab5238cdfe1e1aaf4ea1
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR #4015 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-4.9/d0ad5731a14af5cda547ab5238cdfe1e1aaf4ea1/pr-4015
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!