Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only push PR images to quay if PR label is present #963

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Conversation

gebhardtr
Copy link
Contributor

No description provided.

@gebhardtr gebhardtr added the pr-deployment To trigger a deployment based on this PR's image label Apr 30, 2024
@gebhardtr gebhardtr removed the pr-deployment To trigger a deployment based on this PR's image label Apr 30, 2024
@gebhardtr gebhardtr force-pushed the rg/primages branch 5 times, most recently from 8e62241 to e935899 Compare April 30, 2024 14:54
@gebhardtr gebhardtr added pr-deployment To trigger a deployment based on this PR's image and removed pr-deployment To trigger a deployment based on this PR's image labels Apr 30, 2024
@jameswnl
Copy link
Contributor

@gebhardtr the pr-deployment failed because pr-963 image tag is not there in quay

error in cluster: Back-off pulling image "quay.io/ansible/wisdom-service:pr-963"

@jameswnl jameswnl added pr-deployment To trigger a deployment based on this PR's image and removed pr-deployment To trigger a deployment based on this PR's image labels Apr 30, 2024
@gebhardtr
Copy link
Contributor Author

gebhardtr commented May 1, 2024

Looks like it was this too (#968), preventing it from making it to the push?

Last metadata expiration check: 0:00:18 ago on Tue Apr 30 21:25:02 2024.
Argument 'nginx/common' matches 2 streams ('1.22', '1.24') of module 'nginx', but none of the streams are enabled or default
Unable to resolve argument nginx/common
Error: Problems in request:
broken groups or modules: nginx/common
error building at STEP "RUN dnf module install -y nginx/common": error while running runtime: exit status 1

@gebhardtr gebhardtr added the pr-deployment To trigger a deployment based on this PR's image label May 1, 2024
@jameswnl jameswnl removed the pr-deployment To trigger a deployment based on this PR's image label May 1, 2024
@goneri
Copy link
Contributor

goneri commented May 1, 2024

The Image Build issue is resolved, you can rebase your PR.

@gebhardtr gebhardtr marked this pull request as ready for review May 1, 2024 16:35
@gebhardtr gebhardtr added the pr-deployment To trigger a deployment based on this PR's image label May 1, 2024
@jameswnl jameswnl removed the pr-deployment To trigger a deployment based on this PR's image label May 9, 2024
@gebhardtr gebhardtr added the pr-deployment To trigger a deployment based on this PR's image label May 10, 2024
1 similar comment
@jameswnl
Copy link
Contributor

PR Deployment created in namespace wisdom-pr-963

Look up the wisdom-service url in the cluster

@jameswnl
Copy link
Contributor

PR Deployment created in namespace wisdom-pr-963

Look up the wisdom-service url in the cluster

goneri
goneri previously approved these changes May 28, 2024
goneri
goneri previously approved these changes May 30, 2024
@jameswnl
Copy link
Contributor

we don't need this anymore because we are moved to Konflux build. and PR images there are set to expire after 5 days.
if we want to skip PR image build, we have to modify the tekton workflow https://github.com/ansible/ansible-ai-connect-service/blob/main/.tekton/ansible-ai-connect-service-pull-request.yaml#L227

@gebhardtr
Copy link
Contributor Author

thanks @jameswnl! I resolved the conflict; since the workflow is still present (the triggers are commented out), can we merge this anyway just in case we uncomment the triggers? (at least until we delete the workflow entirely).

@jameswnl
Copy link
Contributor

jameswnl commented Jun 3, 2024

thanks @jameswnl! I resolved the conflict; since the workflow is still present (the triggers are commented out), can we merge this anyway just in case we uncomment the triggers? (at least until we delete the workflow entirely).

it is actually already disabled. it's currently only available for workflow_dispatch -- just keeping this to give Konflux a week or two to warm-up

@gebhardtr
Copy link
Contributor Author

right, the triggers are commented out but the workflow is still present; let's merge this until we delete it (and we can have a record for how to do it in the future).

@jameswnl
Copy link
Contributor

jameswnl commented Jun 3, 2024

right, the triggers are commented out but the workflow is still present; let's merge this until we delete it (and we can have a record for how to do it in the future).

sounds good to me :)

@gebhardtr gebhardtr merged commit d071ffa into main Jun 3, 2024
5 checks passed
@gebhardtr gebhardtr deleted the rg/primages branch June 3, 2024 14:32
@gebhardtr gebhardtr restored the rg/primages branch June 3, 2024 14:32
@gebhardtr gebhardtr deleted the rg/primages branch June 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-deployment To trigger a deployment based on this PR's image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants