-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only push PR images to quay if PR label is present #963
Conversation
8e62241
to
e935899
Compare
Signed-off-by: Richard Gebhardt <[email protected]>
@gebhardtr the pr-deployment failed because error in cluster: |
Looks like it was this too (#968), preventing it from making it to the push?
|
The Image Build issue is resolved, you can rebase your PR. |
1 similar comment
PR Deployment created in namespace wisdom-pr-963 Look up the wisdom-service url in the cluster |
PR Deployment created in namespace wisdom-pr-963 Look up the wisdom-service url in the cluster |
we don't need this anymore because we are moved to Konflux build. and PR images there are set to expire after 5 days. |
thanks @jameswnl! I resolved the conflict; since the workflow is still present (the triggers are commented out), can we merge this anyway just in case we uncomment the triggers? (at least until we delete the workflow entirely). |
it is actually already disabled. it's currently only available for |
right, the triggers are commented out but the workflow is still present; let's merge this until we delete it (and we can have a record for how to do it in the future). |
sounds good to me :) |
No description provided.