Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-compose cannot recognize relative paths correctly #1515

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

TamiTakamiya
Copy link
Contributor

Jira Issue: n/a

Description

podman-compose 1.20 has an issue to recognize relative paths given with -f parameter. (reference)
Since it still can process absolute paths, we'll update our Makefile to use absolute paths by adding ${PWD} in front of relative paths

Testing

Steps to test

  1. Pull down the PR
  2. Run some make targets that uses podman-compose, like make start-backends.

Scenarios tested

Manually ran make targets.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Makefile Show resolved Hide resolved
Copy link
Contributor

@omaciel omaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TamiTakamiya TamiTakamiya merged commit 6e2c1ff into main Jan 30, 2025
9 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/podman-compose-relative-path-issue branch January 30, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants