Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tests for API versions #1512

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

ldjebran
Copy link
Contributor

@ldjebran ldjebran commented Jan 29, 2025

Jira Issue: https://issues.redhat.com/browse/AAP-39022

Description

  • The changes enable to tests different versions of API (the default one is v0).
  • Fixed one bug (there was no return for http delete command for wca apikey endpoint).
  • Added the tests to support v1
  • Added unit-tests for wca endpoints on version v1 when the env is not debug and deployment type is not saas should return http code 501 - not implemented.

Testing

This PR implement testing for different versions

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@ldjebran ldjebran force-pushed the ldjebran/tests_for_versions branch from 3d1d2f3 to aea5d37 Compare January 29, 2025 14:54
This changes we will be able to tests different versions of API.
issue: https://issues.redhat.com/browse/AAP-39022

Signed-off-by: Djebran Lezzoum <[email protected]>
@ldjebran ldjebran force-pushed the ldjebran/tests_for_versions branch from aea5d37 to dd31047 Compare January 29, 2025 17:46
@ldjebran ldjebran changed the title [DO NOT MERGE] Implement tests for API versions Implement tests for API versions Jan 29, 2025
@ldjebran ldjebran marked this pull request as ready for review January 29, 2025 18:02
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Great job.

@ldjebran ldjebran merged commit 014ffab into main Jan 30, 2025
11 checks passed
@ldjebran ldjebran deleted the ldjebran/tests_for_versions branch January 30, 2025 13:43
@manstis manstis mentioned this pull request Jan 30, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants