Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move completion wca view tests to their own file #1505

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

mabashian
Copy link
Member

@mabashian mabashian commented Jan 23, 2025

This PR does not need a corresponding Jira item.

Description

Moves completion wca view tests out to their own file reducing the size of test_views.py

Note that I also removed some leftover unused classes in test_views.py that are unrelated to the completion wca view tests

Testing

Changes are isolated to the unit tests so passing tests should be a good indicator that things are going well

manstis
manstis previously approved these changes Jan 23, 2025
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@mabashian mabashian merged commit 8f0a8da into main Jan 23, 2025
11 checks passed
@mabashian mabashian deleted the mabashian/migrate-test-completion-wca-view branch January 23, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants