-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAP-36732: ModelPipelines: Configuration improvements: Remove env vars #1487
Conversation
5a88ec7
to
3051acc
Compare
0d0074e
to
072a815
Compare
17cba50
to
de5afa1
Compare
Work as expected with the following configuration:
The part I found a bit annoying is that if my YAML syntax is incorrect, the exception is silently ignored. |
Actually my configuration doesn't work because the
|
Excellent find. Thanks. |
@goneri PR updated to better handle exceptions (and fixed |
8c0c083
to
154c04c
Compare
@@ -30,7 +30,7 @@ jobs: | |||
- name: Set up python3 | |||
uses: actions/setup-python@v4 | |||
with: | |||
python-version: '3.10' | |||
python-version: '3.11' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aligns the Python version with the other GHA definition.
3.11
is needed to support ExceptionGroup
(used in this PR). It is also the version used to build the container.
Quality Gate passedIssues Measures |
PR Deployment created in namespace wisdom-pr-1487 Look up the wisdom-service url in the cluster |
See https://issues.redhat.com/browse/AAP-38734 re: failing "PR Deployment Testing" check. I have however deployed the container built by this PR to
|
Jira Issue: https://issues.redhat.com/browse/AAP-36732
Description
This PR removes the discrete (legacy) environment variables previously used to configure LLM services (WCA, Ollama, GRPC etc). All configuration is now controlled by a JSON (or YAML) block, stored in a
ANSIBLE_AI_MODEL_MESH_CONFIG
environment. Various examples are given in this PR.I have included support for the legacy use of environment variables.
These are used if
ANSIBLE_AI_MODEL_MESH_CONFIG
is not set.This is predominantly for the use by the Operator; where an older version uses the latest service version.
Testing
N/A. Internal refactoring of existing code.
Steps to test
N/A. Internal refactoring of existing code.
Scenarios tested
N/A. Internal refactoring of existing code.
Production deployment