Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wcaOnPrem: raise a 404 with feature_not_released_yet for playbook ExpGen #1068

Merged
merged 1 commit into from
May 29, 2024
Merged

wcaOnPrem: raise a 404 with feature_not_released_yet for playbook ExpGen #1068

merged 1 commit into from
May 29, 2024

Conversation

goneri
Copy link
Contributor

@goneri goneri commented May 27, 2024 •
edited
Loading

Description

Raise an err 404 with feature_not_available code when the client tries to access the ExpGen endpoint of a OnPrem server.

Testing

unit-tests

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch from d478ec4 to 848dde0 Compare May 27, 2024 21:30
@goneri goneri requested a review from TamiTakamiya May 27, 2024 21:49
@goneri
Copy link
Contributor Author

goneri commented May 27, 2024

Tests are failing because we need #1055 first

manstis
manstis previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small typo, otherwise LGTM 👍

ansible_wisdom/ai/api/exceptions.py Outdated Show resolved Hide resolved
@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch from 848dde0 to 857ea80 Compare May 28, 2024 13:46
@goneri goneri requested a review from manstis May 28, 2024 13:47
@goneri
Copy link
Contributor Author

goneri commented May 28, 2024

Rebased and typo addressed.

manstis
manstis previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

(The test class/name are mildly vague, but nothing wrong).

@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch from 857ea80 to 1c4c4db Compare May 28, 2024 14:07
@manstis
Copy link
Contributor

manstis commented May 28, 2024

@goneri Let me know when it's green and I'll re-approve..

It's pointless me keep approving it while you're making CI happy.

@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch from 1c4c4db to 23749ed Compare May 28, 2024 14:29
@goneri
Copy link
Contributor Author

goneri commented May 28, 2024

@goneri Let me know when it's green and I'll re-approve..

It's pointless me keep approving it while you're making CI happy.

Yes, sorry for that. There is some side-effects between the tests :-(.

@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch 4 times, most recently from 0fc8b2c to 11b20f5 Compare May 28, 2024 19:54
TamiTakamiya
TamiTakamiya previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch 2 times, most recently from 4c98e33 to 2276e58 Compare May 28, 2024 20:45
robinbobbitt
robinbobbitt requested changes May 28, 2024
View reviewed changes
ansible_wisdom/ai/api/exceptions.py Outdated Show resolved Hide resolved
ansible_wisdom/ai/api/exceptions.py Outdated Show resolved Hide resolved
@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch from 2276e58 to 511005f Compare May 28, 2024 21:44
@goneri goneri changed the title wcaOnPrem: raise a 503 with feature_not_released_yet for playbook ExpGen wcaOnPrem: raise a 404 with feature_not_released_yet for playbook ExpGen May 28, 2024
@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch 2 times, most recently from 9ef68b8 to 3008efe Compare May 28, 2024 22:24
@goneri
wcaOnPrem: raise a 404 with feature_not_available for playbook ExpGen
17a9ea8 
Raise an err 404 with `feature_not_available` code when the client tries
to access the ExpGen endpoint of a OnPrem server.
@goneri goneri force-pushed the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch from 3008efe to 17a9ea8 Compare May 28, 2024 22:34
@goneri goneri requested a review from robinbobbitt May 29, 2024 14:22
@goneri goneri requested a review from manstis May 29, 2024 14:22
manstis
manstis approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goneri goneri merged commit ea90279 into main May 29, 2024
9 checks passed
@goneri goneri deleted the goneri/wcaOnPrem-raise-a-503-with-feature_not_released_yet-for-playbook-ExpGen_7441 branch May 29, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinbobbitt robinbobbitt robinbobbitt approved these changes

@manstis manstis manstis approved these changes

@TamiTakamiya TamiTakamiya TamiTakamiya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goneri @manstis @robinbobbitt @TamiTakamiya