Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up references for authconfig in this repo as well, syntax-er… #184

Conversation

ipruteanu-sie
Copy link
Contributor

@ipruteanu-sie ipruteanu-sie commented Feb 23, 2024

Removing authconfig, as done in AL2023 by @DianaMariaDDM.

Overall Review of Changes:
Authconfig got replaced by Authselect: un-needed prelim task

How has this been tested?:
N/A

@uk-bolly uk-bolly self-assigned this Mar 6, 2024
@uk-bolly uk-bolly mentioned this pull request Mar 6, 2024
uk-bolly added a commit that referenced this pull request Mar 6, 2024
uk-bolly added a commit that referenced this pull request Mar 6, 2024
* Issue #170, PR #181 thanks to @ipruteanu-sie

* issue #182, PR #183 thansk to @ipruteanu-sie

* PR #180 thanks to @ipruteanu-sie and @raabf

* Addressed PR #165 thanks to @ipruteanu-sie

* PT #184 addressed thansk to @ipruteanu-sie

* updated credits

* typo and ssh allow_deny comments

* enable OS check

---------

Signed-off-by: Mark Bolwell <[email protected]>
ipruteanu-sie pushed a commit to siemens/RHEL9-CIS that referenced this pull request Mar 11, 2024
* Issue ansible-lockdown#170, PR ansible-lockdown#181 thanks to @ipruteanu-sie

* issue ansible-lockdown#182, PR ansible-lockdown#183 thansk to @ipruteanu-sie

* PR ansible-lockdown#180 thanks to @ipruteanu-sie and @raabf

* Addressed PR ansible-lockdown#165 thanks to @ipruteanu-sie

* PT ansible-lockdown#184 addressed thansk to @ipruteanu-sie

* updated credits

* typo and ssh allow_deny comments

* enable OS check

---------

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Pruteanu <[email protected]>
@ipruteanu-sie
Copy link
Contributor Author

Closing this PR, as it is already part of devel - March24
Also, with respect to AL23, the major diff is that on RHEL9 authselect is installed by default.

uk-bolly added a commit that referenced this pull request Apr 15, 2024
* Issue #170, PR #181 thanks to @ipruteanu-sie

Signed-off-by: Mark Bolwell <[email protected]>

* issue #182, PR #183 thansk to @ipruteanu-sie

Signed-off-by: Mark Bolwell <[email protected]>

* PR #180 thanks to @ipruteanu-sie and @raabf

Signed-off-by: Mark Bolwell <[email protected]>

* Addressed PR #165 thanks to @ipruteanu-sie

Signed-off-by: Mark Bolwell <[email protected]>

* PT #184 addressed thansk to @ipruteanu-sie

Signed-off-by: Mark Bolwell <[email protected]>

* updated credits

Signed-off-by: Mark Bolwell <[email protected]>

* typo and ssh allow_deny comments

Signed-off-by: Mark Bolwell <[email protected]>

* enable OS check

Signed-off-by: Mark Bolwell <[email protected]>

* PR - #198 addressed thanks to @brakkio86

Signed-off-by: Mark Bolwell <[email protected]>

* Addressed issue #190

Signed-off-by: Mark Bolwell <[email protected]>

* Additional vars for issue #190

Signed-off-by: Mark Bolwell <[email protected]>

* updated pre-commit version

Signed-off-by: Mark Bolwell <[email protected]>

* consistent quotes around mode

Signed-off-by: Mark Bolwell <[email protected]>

* moved audit added discoveries

Signed-off-by: Mark Bolwell <[email protected]>

* removed unneeded vars

Signed-off-by: Mark Bolwell <[email protected]>

* audit moved to prelim

Signed-off-by: Mark Bolwell <[email protected]>

* tidy up

Signed-off-by: Mark Bolwell <[email protected]>

* improved new variable usage

Signed-off-by: Mark Bolwell <[email protected]>

* fixed logic 6.2.10

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* addressed #197 thanks to @mark-tomich

Signed-off-by: Mark Bolwell <[email protected]>

* updates for audit section

Signed-off-by: Mark Bolwell <[email protected]>

* fixed naming

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* added prelim to includes

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants