Prepare release 5.1.0 #864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prepare release 4.0.0 * update documentation
…le-collections#739) Drop support for ansible-core<2.15 SUMMARY Remove support for ansible-core<2.15 ISSUE TYPE Feature Pull Request Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 8363a4d) Co-authored-by: Bikouo Aubin <[email protected]>
…sible-collections#740) Defer removal of inventory/k8s to 6.0.0 SUMMARY Defer removal of inventory plugin k8s to release 6.0.0. ISSUE TYPE Feature Pull Request Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 0c5233a) Co-authored-by: Bikouo Aubin <[email protected]>
…ons#741) (ansible-collections#744) [PR ansible-collections#741/fb80d973 backport][stable-5] Doc: add example of using kubectl connection plugin This is a backport of PR ansible-collections#741 as merged into main (fb80d97). SUMMARY Currently documentation for collection don't include any examples of using kubenrenes.core.kubectl connection plugin and it's hard to start using that plugin. ISSUE TYPE Docs Pull Request COMPONENT NAME kubenrenes.core.kubectl connection plugin ADDITIONAL INFORMATION This PR was inspired by ansible-collections#288 and based on feedback on that PR and my own experience. Thanks @tpo for his try and @geerlingguy for his Ansible for DevOps book Reviewed-by: Mike Graves <[email protected]>
…ible-collections#745) (ansible-collections#754) This is a backport of PR ansible-collections#745 as merged into main (6a04f42). SUMMARY If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex. The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true ISSUE TYPE Bugfix Pull Request COMPONENT NAME helm helm_pull ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]>
…e collection cross testing (ansible-collections#760) This is a backport of PR ansible-collections#731 as merged into main (c0666a5). SUMMARY The kubevirt.core collection has dependency with this collection. We define new workflows to ensure that nothing is broken on that collection when pushing new changes on this collection. ISSUE TYPE Feature Pull Request COMPONENT NAME CI Reviewed-by: Mike Graves <[email protected]>
…ollections#756) (ansible-collections#762) This is a backport of PR ansible-collections#756 as merged into main (b07fbd6). Fixes ansible-collections#755 SUMMARY Because we don't have any node with non_exisiting_label (see code below) desired number of Pods will be 0. Kubernetes won't create .status.updatedNumberScheduled field (at least on version v1.27), because we still are not going to create any Pods. So that if .status.updatedNumberScheduled doesn't exist we should assume that number is 0 Code to reproduce: - name: Create daemonset kubernetes.core.k8s: state: present wait: true definition: apiVersion: apps/v1 kind: DaemonSet metadata: name: my-daemonset namespace: default spec: selector: matchLabels: app: my-app template: metadata: labels: app: my-app spec: containers: - name: my-container image: nginx nodeSelector: non_exisiting_label: 1 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubernetes.core.plugins.module_utils.k8s.waiter ADDITIONAL INFORMATION TASK [Create daemonset] ********************************************************************************************************************************** changed: [controlplane] => {"changed": true, "duration": 5, "method": "create", "result": {"apiVersion": "apps/v1", "kind": "DaemonSet", "metadata": {"annotations": {"deprecated.daemonset.template.generation": "1"}, "creationTimestamp": "2024-06-28T08:23:41Z", "generation": 1, "managedFields": [{"apiVersion": "apps/v1", "fieldsType": "FieldsV1", "fieldsV1": {"f:metadata": {"f:annotations": {".": {}, "f:deprecated.daemonset.template.generation": {}}}, "f:spec": {"f:revisionHistoryLimit": {}, "f:selector": {}, "f:template": {"f:metadata": {"f:labels": {".": {}, "f:app": {}}}, "f:spec": {"f:containers": {"k:{\"name\":\"my-container\"}": {".": {}, "f:image": {}, "f:imagePullPolicy": {}, "f:name": {}, "f:resources": {}, "f:terminationMessagePath": {}, "f:terminationMessagePolicy": {}}}, "f:dnsPolicy": {}, "f:nodeSelector": {}, "f:restartPolicy": {}, "f:schedulerName": {}, "f:securityContext": {}, "f:terminationGracePeriodSeconds": {}}}, "f:updateStrategy": {"f:rollingUpdate": {".": {}, "f:maxSurge": {}, "f:maxUnavailable": {}}, "f:type": {}}}}, "manager": "OpenAPI-Generator", "operation": "Update", "time": "2024-06-28T08:23:41Z"}, {"apiVersion": "apps/v1", "fieldsType": "FieldsV1", "fieldsV1": {"f:status": {"f:observedGeneration": {}}}, "manager": "kube-controller-manager", "operation": "Update", "subresource": "status", "time": "2024-06-28T08:23:41Z"}], "name": "my-daemonset", "namespace": "default", "resourceVersion": "1088421", "uid": "faafdbf7-4388-4cec-88d5-84657966312d"}, "spec": {"revisionHistoryLimit": 10, "selector": {"matchLabels": {"app": "my-app"}}, "template": {"metadata": {"creationTimestamp": null, "labels": {"app": "my-app"}}, "spec": {"containers": [{"image": "nginx", "imagePullPolicy": "Always", "name": "my-container", "resources": {}, "terminationMessagePath": "/dev/termination-log", "terminationMessagePolicy": "File"}], "dnsPolicy": "ClusterFirst", "nodeSelector": {"non_exisiting_label": "1"}, "restartPolicy": "Always", "schedulerName": "default-scheduler", "securityContext": {}, "terminationGracePeriodSeconds": 30}}, "updateStrategy": {"rollingUpdate": {"maxSurge": 0, "maxUnavailable": 1}, "type": "RollingUpdate"}}, "status": {"currentNumberScheduled": 0, "desiredNumberScheduled": 0, "numberMisscheduled": 0, "numberReady": 0, "observedGeneration": 1}}} ~$ kubectl get ds NAME DESIRED CURRENT READY UP-TO-DATE AVAILABLE NODE SELECTOR AGE my-daemonset 0 0 0 0 0 non_exisiting_label=1 30s Reviewed-by: Mike Graves <[email protected]>
…tions#728) (ansible-collections#764) This is a backport of PR ansible-collections#728 as merged into main (5bc53db). SUMMARY error judgments are based on the exit codes of command execution, where 0 represents success and non-zero represents failure. Optimize the run_command function to return a tuple like the run_command method of AnsibleModule. Fixes ansible-collections#639 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kustomize lookup plugin ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]>
…collections#812) This is a backport of PR ansible-collections#789 as merged into main (cd68631). This PR includes a trivial fix for the GitHub Actions issue ansible-collections#788 and related to switching milestone and devel branches of ansible/ansible to version 2.19 and prepare repo to be ready to include test with Python 3.13 when ansible-network/github_actions/pull/162 is merged. ISSUE TYPE Bugfix Pull Request COMPONENT NAME GitHub actions/test Reviewed-by: Mike Graves <[email protected]>
…nsible-collections#810) This is a backport of PR ansible-collections#806 as merged into main (513ff66). SUMMARY This removes the kubevirt integration tests. We don't maintain that collection or have any permissions on that repo, so there's no reason for these tests to be here. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]>
…e-collections#793) (ansible-collections#808) This is a backport of PR ansible-collections#793 as merged into main (fca0dc0). SUMMARY Fixes ansible-collections#792 . The function wait_for_pod_deletion in k8s_drain never checks on which node a pod is actually running: try: response = self._api_instance.read_namespaced_pod( namespace=pod[0], name=pod[1] ) if not response: pod = None time.sleep(wait_sleep) This means that if a pod is successfully evicted and restarted with the same name on a new node, k8s_drain does not notice and thinks that the original pod is still running. This is the case for pods which are part of a stateful set. ISSUE TYPE Bugfix Pull Request COMPONENT NAME k8s_drain
…e-collections#814) This is a backport of PR ansible-collections#750 as merged into main (d192157). SUMMARY Minor/cosmetic documentation change with adding release 3.2.0 to changelog for master as the release is from stable-3 branch ISSUE TYPE Docs Pull Request COMPONENT NAME CHANGELOG.md ADDITIONAL INFORMATION Most probably this PR should be backported to the stable-5 branch after the merge to the main and should be with a skip-changelog tag.
…nsible-collections#798) (ansible-collections#816) This is a backport of PR ansible-collections#798 as merged into main (52f2cb5). SUMMARY Closes ansible-collections#797 . The error message "Too Many Requests" is confusing and is changed to a more meaningful message: TASK [Drain node] ************************************************************************* Montag 25 November 2024 09:20:28 +0100 (0:00:00.014) 0:00:00.014 ******* fatal: [host -> localhost]: FAILED! => {"changed": false, "msg": "Failed to delete pod kube-public/draintest-6b84677b99-9jf7m due to: Cannot evict pod as it would violate the pod's disruption budget."} The new task output would allow to deal with a pod disruption budget with the retries/until logic in a more controlled way: --- - hosts: "{{ target }}" serial: 1 gather_facts: false tasks: - name: Drain node kubernetes.core.k8s_drain: kubeconfig: "{{ kubeconfig_path }}" name: "{{ inventory_hostname }}" delete_options: ignore_daemonsets: true delete_emptydir_data: true wait_timeout: 100 disable_eviction: false wait_sleep: 1 delegate_to: localhost retries: 10 delay: 5 until: drain_result is success or 'disruption budget' not in drain_result.msg register: drain_result ISSUE TYPE Feature Pull Request COMPONENT NAME k8s_drain
…-collections#817) This is a backport of PR ansible-collections#749 as merged into main (0afd257). SUMMARY This PR fixes shields.io badges in README.md. It's just cosmetic bugfix ISSUE TYPE Bugfix Pull Request COMPONENT NAME README.md ADDITIONAL INFORMATION Current README.md: This PR:
…sible-collections#818) This is a backport of PR ansible-collections#765 as merged into main (a89f19b). SUMMARY Bump the ansible-lint version to 24.7.0 ISSUE TYPE COMPONENT NAME ADDITIONAL INFORMATION
…e-collections#819) This is a backport of PR ansible-collections#767 as merged into main (fdb8af7). SUMMARY Refer: https://issues.redhat.com/browse/ACA-1749 This PR updates the README doc to match the template ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
…#770) (ansible-collections#820) This is a backport of PR ansible-collections#770 as merged into main (4c305e7). SUMMARY Fixes ansible-collections#769 . k8s_drain was not checking if a pod has been deleted when there was only one pod on the node to be drained. The list of pods, pods, was being "popped" before the first iteration of the while loop: pod = pods.pop() while (_elapsed_time() < wait_timeout or wait_timeout == 0) and pods: When pods contains only one element, the while loop is skipped. ISSUE TYPE Bugfix Pull Request COMPONENT NAME k8s_drain
…lections#774) (ansible-collections#823) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]>
…ions#824) This is a backport of PR ansible-collections#778 as merged into main (c8a9326). SUMMARY As a part of https://forum.ansible.com/t/proposal-consolidating-ansible-discussion-platforms/6812 ISSUE TYPE Docs Pull Request COMPONENT NAME CONTRIBUTING.md
…le-collections#790) (ansible-collections#825) This is a backport of PR ansible-collections#790 as merged into main (b8e9873). SUMMARY As part of the consolidating Ansible discussion platforms and communication channels was decided to use the Ansible forum as the main place for questions and discussion. Reference: https://forum.ansible.com/t/proposal-consolidating-ansible-discussion-platforms/6812 As part of this change, the IRC channel was removed by the PRs ansible-collections#778 and ansible-collections#774. However, the README.md file wasn't fully cleaned up from the outdated information. The #ansible-kubernetes channel on libera.chat IRC isn't used by maintainers and contributors anymore. The Wiki page on the https://github.com/ansible/community/ was deprecated a long time ago ISSUE TYPE Docs Pull Request COMPONENT NAME README.md
This is a backport of PR ansible-collections#827 as merged into main (c8a33c7). SUMMARY Some of the charts we've used for testing are no longer available at the old helm repository urls, as they've been moved to oci registries. This updates those charts. In the longer term, we should find a better way to handle these kinds of test fixtures, probably by switching to local charts as much as possible. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin
…ions#833) SUMMARY Fix charts ref on integration tests targets ISSUE TYPE Bugfix Pull Request Reviewed-by: Yuriy Novostavskiy Reviewed-by: Alina Buzachis (cherry picked from commit 7559b65) Co-authored-by: Bikouo Aubin <[email protected]>
…ns#805) (ansible-collections#835) * Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (cherry picked from commit 6609abd) Co-authored-by: Yuriy Novostavskiy <[email protected]>
* fix: typo replaces ansible-collections#799 * doc: add changelog fragment * Delete changelogs/fragments/804-drain-typo.yaml --------- Co-authored-by: Bikouo Aubin <[email protected]> (cherry picked from commit 219c747) Co-authored-by: Pierre Ozoux <[email protected]>
…ns#826) (ansible-collections#840) (cherry picked from commit 6efabd3) Co-authored-by: Bikouo Aubin <[email protected]>
…llections#800) (ansible-collections#836) * new module helm_registry_auth * Initial integration tests * final update copyright and integration test before pr * update link to pr in changelog fragment * reformat plugins/module_utils/helm.py with black to fix linters in actions * attempt to fix unit test unit test was missing initially * fix https://pycqa.github.io/isort/ linter * next attemp to fix unit-test * remove unused and unsupported helm_args_common * remove unused imports and fix other linters errors * another fix for unit test * fix issue introducied by commit ff02893 * add binary_path to arg_spec * return helm_cmd in the output of check mode remove changlog fragment * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * description suggestion from reviewer/maintainer Co-authored-by: Bikouo Aubin <[email protected]> * remove changed from module return Co-authored-by: Bikouo Aubin <[email protected]> * remove redundant code Co-authored-by: Bikouo Aubin <[email protected]> * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * consider support of logout when user is not logged in Co-authored-by: Bikouo Aubin <[email protected]> * consider support helm < 3.0.0 * Revert "consider support helm < 3.0.0" This reverts commit f20004d. * reintroduce support of helm version less than 3.8.0 reference: https://helm.sh/docs/topics/registries/#enabling-oci-support-prior-to-v380 * revert reintroducing support of helm < 3.8.0 reason: didn't find a quick way to deal with tests * update documentation with the recent module updates * Update plugins/modules/helm_registry_auth.py Co-authored-by: Bikouo Aubin <[email protected]> * add test of logout impendency Co-authored-by: Bikouo Aubin <[email protected]> * fix linters * fix intendations in the integration tests * create tests/integration/targets/helm_registry_auth/aliases * fix integration test (typo) * fix integration tests (test wrong cred) * add stderr when module fail * another attempt to fix integration test * fix assertion in integration test to be not affceted by the ansible-collections#830 --------- Co-authored-by: Bikouo Aubin <[email protected]> (cherry picked from commit aee8474) Co-authored-by: Yuriy Novostavskiy <[email protected]>
…s#854) This is a backport of PR ansible-collections#852 as merged into main (9f60b15). SUMMARY The helm_set_values test target did not clean up its namespace which is leading to unstable tests in the k8s_drain target. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION
…ections#849) This is a backport of PR ansible-collections#848 as merged into main (159a63a). SUMMARY After the release 25.0.0 of ansible-compat the linters in CI become failing. In the ansible-lint issue already created COMPONENT NAME .github/workflows/linters.yaml ADDITIONAL INFORMATION Fix bug ansible-collections#846 within this commit ansible/ansible-lint is updated to 24.12.2 and the ansible-lint config moved to the .config folder
…sible-collections#858) This is a backport of PR ansible-collections#796 as merged into main (ecc64ca). SUMMARY Apply no_log=True to pass_credentials to silence false positive warning. Fixes similar issue to: ansible-collections#423 ISSUE TYPE Bugfix Pull Request COMPONENT NAME changelog/fragements/796-false-positive-helmull.yaml plugins/modules/helm_pull.py
ansible-collections#838) (ansible-collections#860) SUMMARY I noticed that even config for probot/stale is present in the repo, but the old issues and PRs weren't marked as stale and not closed by the bot. Investigated and found that this bot was added to community.kubernetes as ansible-collections/community.kubernetes#53 but wasn't moved to kubernetes.core and never worked here. Moreover, this bot is completely deprecated and down, ref: probot/stale#430 So, the config to be removed. ISSUE TYPE Bugfix Pull Request COMPONENT NAME .github/stale.yml ADDITIONAL INFORMATION Closes ansible-collections#837 Trivial change that not require changelog Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit eb731cd) Co-authored-by: Yuriy Novostavskiy <[email protected]>
…ble-collections#856) This is a backport of PR ansible-collections#831 as merged into main (bc0de24). SUMMARY Some parameters were added to the master in time where the latest version was 2.4.0 with version_added: 2.5.0, however the next version after 2.4.0 was a 3.0.0. So, with this trivial doc PR (that most probably doesn't require a changelog fragment and including to changelog) I replacing version_added: 2.5.0 to version_added: 3.0.0 for: reuse_values in kubernetes.core.helm module reset_values in kubernetes.core.helm module delete_all in kubernetes.core.k8s module hidden_fields in kubernetes.core.k8s module hidden_fields in kubernetes.core.k8s_info module All of them are introduced in kubernetes.core 3.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME helm k8s 8s_info ADDITIONAL INFORMATION PR to be backported to stable-3 and stable-5
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
PR to wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This release came with new module
helm_registry_auth, and improvements to the error messages in the k8s_drain module, new parameterinsecure_registryforhelm_templatemodule and several bug fixes.ISSUE TYPE
Changelog
Minor Changes
Bugfixes
New Modules
ADDITIONAL INFORMATION
Collection kubernets.core version 3.1.0 is compatible with ansible-core>=2.15.0