Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows.yml #996

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update Windows.yml #996

merged 2 commits into from
Jun 7, 2024

Conversation

denser
Copy link
Contributor

@denser denser commented May 23, 2023

Due windows locales, correct detecting of arch.

In my locale windows arch cant detected in proper way, so we should search just 64 not full string

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

May be should fix not just agent role but others too.

Due windows locales, correct detecting of arch.
@pyrodie18
Copy link
Collaborator

COMPONENT NAME

May be should fix not just agent role but others too.

The agent role is the only role that supports Windows. Do me a favor and create a change fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment)

Copy link
Collaborator

@pyrodie18 pyrodie18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add change fragment please

@pyrodie18 pyrodie18 merged commit 321e642 into ansible-collections:main Jun 7, 2024
87 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants