Fixed IPMI authentication algorithm default setting #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGmot
approved these changes
Mar 4, 2024
|
Thanks @balakine ! |
pyrodie18
pushed a commit
to pyrodie18/community.zabbix
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
roles/zabbix_agent
ADDITIONAL INFORMATION
zabbix_agent_ipmi_authtype description and default value are duplicating those of zabbix_agent_ipmi_privilege. This is obviously wrong. See Host object API documentation. You have it correct in plugins/modules/zabbix_proxy_info.py. To reproduce the issue assign a zabbix_agent role to a host, don't set IPMI variables, and observe IPMI field in Zabbix to get set to MD5, not left as default.
It is hypothetically possible that someone might have relied on the wrong default setting and didn't set it explicitly in their inventory, so technically it's a breaking change.