first shot at building docs on PRs with shared workflow #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I've spent my holiday reimplementing the docs build process so it can be shared with other collections in a way that's straightforward.
What I'm proposing here is a first step at re-using that stuff to have a docs build in this collection, on PRs.
It's quite short, because it's using the basics of the shared workflows/actions I created, with mostly default parameters.
There's no publishing step here, because that will need you to sign up with some other service and put any relevant secrets you need into GitHub.
However, you can see what that looks like in the workflow I'm using where I publish to Surge. I made that as a shared workflow, so that if anyone else wants to use it, it's super straightforward to do so.
Maybe we'll see some shared workflows or other publishing destinations like RTD.
So here's a few things about this PR:
pull_request_target
trigger, so it will not be run in this PR. Unfortunately this means it can't be tested in this PR either; it will have to be landed tomain
first before we can test against changes to it. After that, the process of testing changes is a little complicated, to see more details about that, read docs build - process notes and TODOs community.hashi_vault#138 (perhaps skip toPut workflow changes on a direct branch, open other PRs against the branch
).main
, it can be tested immediately by putting up a test PR (from a fork works too).ISSUE TYPE
COMPONENT NAME
ansible collection docs
ADDITIONAL INFORMATION
N/A