Skip to content

Merge pull request #260 from davidrusu/resolve-build-warnings #537

Merge pull request #260 from davidrusu/resolve-build-warnings

Merge pull request #260 from davidrusu/resolve-build-warnings #537

GitHub Actions / Clippy (beta) succeeded Mar 23, 2024 in 0s

Clippy (beta)

41 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 41
Note 0
Help 0

Versions

  • rustc 1.78.0-beta.1 (efd9d2df1 2024-03-18)
  • cargo 1.78.0-beta.1 (2fe739fcf 2024-03-15)
  • clippy 0.1.78 (efd9d2d 2024-03-18)

Annotations

Check warning on line 55 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

empty doc comment

warning: empty doc comment
  --> taiga_halo2/src/taiga_api.rs:55:1
   |
55 | ///
   | ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `-W clippy::empty-docs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`

Check warning on line 135 in taiga_halo2/src/resource_encryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> taiga_halo2/src/resource_encryption.rs:135:25
    |
135 |     pub fn padding(msg: &Vec<pallas::Base>) -> Self {
    |                         ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
    |
135 ~     pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~         let mut plaintext = msg.to_owned();
    |

Check warning on line 55 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

empty doc comment

warning: empty doc comment
  --> taiga_halo2/src/taiga_api.rs:55:1
   |
55 | ///
   | ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `-W clippy::empty-docs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`

Check warning on line 135 in taiga_halo2/src/resource_encryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> taiga_halo2/src/resource_encryption.rs:135:25
    |
135 |     pub fn padding(msg: &Vec<pallas::Base>) -> Self {
    |                         ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
    |
135 ~     pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~         let mut plaintext = msg.to_owned();
    |

Check warning on line 979 in taiga_halo2/src/circuit/blake2s.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> taiga_halo2/src/circuit/blake2s.rs:979:30
    |
979 |     pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 434 in taiga_halo2/src/circuit/blake2s.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> taiga_halo2/src/circuit/blake2s.rs:434:14
    |
434 |         ret: &Vec<Blake2sWord<F>>,
    |              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `-W clippy::ptr-arg` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`

Check warning on line 150 in taiga_halo2/src/circuit/vp_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of a fallible conversion when an infallible one could be used

warning: use of a fallible conversion when an infallible one could be used
   --> taiga_halo2/src/circuit/vp_circuit.rs:150:13
    |
150 |         val.try_into()
    |             ^^^^^^^^ help: use: `into`
    |
    = note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
    = note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`

Check warning on line 979 in taiga_halo2/src/circuit/blake2s.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> taiga_halo2/src/circuit/blake2s.rs:979:30
    |
979 |     pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 434 in taiga_halo2/src/circuit/blake2s.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> taiga_halo2/src/circuit/blake2s.rs:434:14
    |
434 |         ret: &Vec<Blake2sWord<F>>,
    |              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `-W clippy::ptr-arg` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`

Check warning on line 150 in taiga_halo2/src/circuit/vp_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of a fallible conversion when an infallible one could be used

warning: use of a fallible conversion when an infallible one could be used
   --> taiga_halo2/src/circuit/vp_circuit.rs:150:13
    |
150 |         val.try_into()
    |             ^^^^^^^^ help: use: `into`
    |
    = note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
    = note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`

Check warning on line 8 in taiga_halo2/src/vp_commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/vp_commitment.rs:8:5
  |
8 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 9 in taiga_halo2/src/transparent_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/transparent_ptx.rs:9:5
  |
9 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 19 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/transaction.rs:19:5
   |
19 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 234 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `OsRng` is imported redundantly

warning: the item `OsRng` is imported redundantly
   --> taiga_halo2/src/taiga_api.rs:234:9
    |
232 |         taiga_api::*,
    |         ------------ the item `OsRng` is already imported here
233 |     };
234 |     use rand::rngs::OsRng;
    |         ^^^^^^^^^^^^^^^^^

Check warning on line 22 in taiga_halo2/src/shielded_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/shielded_ptx.rs:22:5
   |
22 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 28 in taiga_halo2/src/resource.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/resource.rs:28:5
   |
28 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 12 in taiga_halo2/src/proof.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/proof.rs:12:5
   |
12 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 16 in taiga_halo2/src/nullifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/nullifier.rs:16:5
   |
16 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 17 in taiga_halo2/src/merkle_tree.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/merkle_tree.rs:17:5
   |
17 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 12 in taiga_halo2/src/delta_commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/delta_commitment.rs:12:5
   |
12 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 8 in taiga_halo2/src/vp_commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/vp_commitment.rs:8:5
  |
8 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 9 in taiga_halo2/src/transparent_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/transparent_ptx.rs:9:5
  |
9 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 19 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/transaction.rs:19:5
   |
19 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 22 in taiga_halo2/src/shielded_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/shielded_ptx.rs:22:5
   |
22 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 28 in taiga_halo2/src/resource.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/resource.rs:28:5
   |
28 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude