Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/rpc: small improvements #4223

Merged
merged 1 commit into from
Jan 9, 2025
Merged

client/rpc: small improvements #4223

merged 1 commit into from
Jan 9, 2025

Conversation

tzemanovic
Copy link
Member

Describe your changes

A quick follow-up for unresolved threads from #4205

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic requested a review from brentstone January 7, 2025 15:11
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (be0e986) to head (e67f96d).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
+ Coverage   74.44%   74.46%   +0.01%     
==========================================
  Files         342      342              
  Lines      107785   107785              
==========================================
+ Hits        80243    80257      +14     
+ Misses      27542    27528      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 9, 2025
mergify bot added a commit that referenced this pull request Jan 9, 2025
@mergify mergify bot merged commit 9527ea9 into main Jan 9, 2025
24 of 25 checks passed
@mergify mergify bot deleted the tomas/next-epoch-followup branch January 9, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants