TEMP - don't merge

.changelog/unreleased/improvements/4209-increase-max-pgf-actions.md

@@ -0,0 +1,2 @@
+- Increase the allowed number of PGF targets in a single proposal from 20 to
+  1000. ([\#4209](https://github.com/anoma/namada/pull/4209))

crates/governance/src/finalize_block.rs

@@ -500,26 +500,33 @@ where
                         result
                     }
                     PGFTarget::Ibc(target) => {
-                        let result = transfer_over_ibc(
-                            storage,
-                            token,
-                            &PGF_ADDRESS,
-                            target,
-                        );
-                        if result.is_ok() {
-                            Token::emit_transfer_event(
+                        for i in 0..10_000 {
+                            let result = transfer_over_ibc(
                                 storage,
-                                "pgf-payments-over-ibc".into(),
-                                EventLevel::Block,
                                 token,
-                                target.amount,
-                                token::UserAccount::Internal(PGF_ADDRESS),
-                                token::UserAccount::External(
-                                    target.target.clone(),
-                                ),
-                            )?;
+                                &PGF_ADDRESS,
+                                target,
+                            );
+                            tracing::info!(
+                                "IBC PGF transfer {i}, is success: {}",
+                                result.is_ok()
+                            );
+                            if result.is_ok() {
+                                Token::emit_transfer_event(
+                                    storage,
+                                    "pgf-payments-over-ibc".into(),
+                                    EventLevel::Block,
+                                    token,
+                                    target.amount,
+                                    token::UserAccount::Internal(PGF_ADDRESS),
+                                    token::UserAccount::External(
+                                        target.target.clone(),
+                                    ),
+                                )?;
+                            }
+                            result?
                         }
-                        result
+                        Ok(())
                     }
                 };
                 match result {

crates/governance/src/vp/mod.rs

@@ -28,7 +28,7 @@ use crate::ProposalVote;
 pub const ADDRESS: Address = Address::Internal(InternalAddress::Governance);
 
 /// The maximum number of item in a pgf proposal
-pub const MAX_PGF_ACTIONS: usize = 20;
+pub const MAX_PGF_ACTIONS: usize = 1000;
 
 #[allow(missing_docs)]
 #[derive(Error, Debug)]
@@ -505,8 +505,9 @@ where
 
                 if !is_total_fundings_valid {
                     return Err(Error::new_alloc(format!(
-                        "Maximum number of funding actions \
-                         ({MAX_PGF_ACTIONS}) exceeded ({})",
+                        "Maximum number of funding targets \
+                         ({MAX_PGF_ACTIONS}) exceeded by the provided amount \
+                         of ({})",
                         fundings.len()
                     )));
                 }

crates/tests/src/e2e/ibc_tests.rs

@@ -652,7 +652,7 @@ fn pgf_over_ibc() -> Result<()> {
         ALBERT,
         PGF_ADDRESS.to_string(),
         NAM,
-        100,
+        1_000_000,
         ALBERT_KEY,
         &[],
     )?;
@@ -694,7 +694,7 @@ fn pgf_over_ibc() -> Result<()> {
     let token_addr = find_address(&test, NAM)?;
     let ibc_denom = format!("{port_id_gaia}/{channel_id_gaia}/{token_addr}");
     check_cosmos_balance(&test_gaia, COSMOS_RELAYER, &ibc_denom, 10_000_000)?;
-    check_cosmos_balance(&test_gaia, COSMOS_USER, &ibc_denom, 5_000_000)?;
+    check_cosmos_balance(&test_gaia, COSMOS_USER, &ibc_denom, 50_000_000_000)?;
 
     Ok(())
 }