Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Packet Forward Middleware #4082

Merged
merged 7 commits into from
Jan 20, 2025
Merged

IBC Packet Forward Middleware #4082

merged 7 commits into from
Jan 20, 2025

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Nov 22, 2024

Describe your changes

Integrate with the Packet Forward Middleware code. Requires an ibc-rs fork, in order to support asynchronous IBC packet acknowledgements.

NOTE: The code in the links above should also be reviewed.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 58.29493% with 181 lines in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (867e20d) to head (014a23f).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/context/pfm_mod.rs 56.25% 175 Missing ⚠️
crates/ibc/src/context/nft_transfer_mod.rs 33.33% 2 Missing ⚠️
crates/ibc/src/context/transfer_mod.rs 33.33% 2 Missing ⚠️
crates/ibc/src/context/token_transfer.rs 0.00% 1 Missing ⚠️
crates/ibc/src/lib.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4082      +/-   ##
==========================================
- Coverage   74.59%   74.52%   -0.08%     
==========================================
  Files         342      343       +1     
  Lines      108796   109208     +412     
==========================================
+ Hits        81152    81382     +230     
- Misses      27644    27826     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm branch from 0cf7093 to dc3950c Compare November 29, 2024 14:09
@sug0
Copy link
Collaborator

sug0 commented Nov 29, 2024

(before rebase/history cleanup: dc3950c)

sug0 added a commit that referenced this pull request Nov 29, 2024
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm branch from dc3950c to c9c8d57 Compare November 29, 2024 14:35
sug0 added a commit that referenced this pull request Nov 29, 2024
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm branch from c9c8d57 to 7b6135d Compare November 29, 2024 14:37
@sug0 sug0 requested review from tzemanovic, yito88 and grarco November 29, 2024 14:38
@sug0 sug0 added this to the Future breaking upgrade milestone Nov 29, 2024
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left trivial comments.

Cargo.toml Outdated Show resolved Hide resolved
crates/tests/src/e2e/helpers.rs Outdated Show resolved Hide resolved
sug0 added a commit that referenced this pull request Dec 1, 2024
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm branch from 7b6135d to 6d01475 Compare December 1, 2024 08:56
sug0 added a commit that referenced this pull request Dec 1, 2024
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm branch from 6d01475 to 08669c1 Compare December 1, 2024 09:38
@sug0
Copy link
Collaborator

sug0 commented Dec 18, 2024

(rebased on latest main)

sug0 added a commit that referenced this pull request Dec 18, 2024
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm branch from d50cccd to 878ca57 Compare December 18, 2024 14:34
batconjurer pushed a commit that referenced this pull request Dec 27, 2024
sug0 added a commit that referenced this pull request Jan 13, 2025
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm branch from 878ca57 to bbc1cb1 Compare January 13, 2025 13:17
@tzemanovic
Copy link
Member

I'll rebase and merge

@tzemanovic tzemanovic force-pushed the bat+tiago/feat/ibc-pfm branch from bbc1cb1 to 014a23f Compare January 20, 2025 15:20
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 20, 2025
@mergify mergify bot merged commit 014a23f into main Jan 20, 2025
15 of 19 checks passed
@mergify mergify bot deleted the bat+tiago/feat/ibc-pfm branch January 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking: protocol breaking: tx enhancement New feature or request IBC ledger merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants