Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1329: Extension - Chain validation sometimes fails #1336

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Nov 28, 2024

As the extension only needs to know the chainId in order to validate signing requests, remove complex chain config and the associated validation (this is causing issues where old versions of the extension cannot update, and breaks the App popup!)

  • Simply chain service, only track chain ID
  • Remove unused Namada calls for getChain, etc.
  • Remove any other unused items
  • Fix any broken tests

Testing

  • Simply load this version if you're already running a local dev extension - it should gracefully update to the new storage and not throw any errors!
  • To test signing, until feat/1295 - Update Namada Keychain integration #1298 is merged, you'll have to set the Network chain ID again, since it will revert to a default value

TODO

@jurevans jurevans force-pushed the bug/1329-update-chain-service branch from 8aaefcc to 4d67891 Compare November 28, 2024 11:13
Copy link
Collaborator

@pedrorezende pedrorezende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good refactor! 🥇

apps/extension/src/background/sdk/service.ts Outdated Show resolved Hide resolved
@jurevans jurevans force-pushed the bug/1329-update-chain-service branch from 3351ab6 to 9a22c08 Compare November 28, 2024 11:51
@jurevans jurevans force-pushed the bug/1329-update-chain-service branch from 9a22c08 to 6069753 Compare November 28, 2024 12:00
@jurevans jurevans changed the title bug/1329: Extension - Simplify chain service bug/1329: Extension - Chain validation sometimes fails Nov 28, 2024
@jurevans jurevans merged commit 596478c into main Nov 28, 2024
10 checks passed
@jurevans jurevans deleted the bug/1329-update-chain-service branch November 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Extension bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants