Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR][MARCHE INCLUSION] Use DataProcessor #451

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[REFACTOR][MARCHE INCLUSION] Use DataProcessor #451

merged 1 commit into from
Jan 8, 2025

Conversation

hacherix
Copy link
Contributor

@hacherix hacherix commented Jan 8, 2025

Related to #405

DAG has been refactored to use the DataProcessor class.

image

@hacherix hacherix self-assigned this Jan 8, 2025
@hacherix hacherix requested a review from HAEKADI as a code owner January 8, 2025 09:01
HAEKADI
HAEKADI approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@HAEKADI HAEKADI left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐎
I have the same feedback about the file names. It should not contain the name of the data source for all data sources of added to all of them. For consistency 🤣

@hacherix hacherix force-pushed the refactor-marche-inclusion branch from b77f605 to b713e75 Compare January 8, 2025 16:16
@hacherix
Copy link
Contributor Author

hacherix commented Jan 8, 2025

lgtm 🐎 I have the same feedback about the file names. It should not contain the name of the data source for all data sources of added to all of them. For consistency 🤣

File names changed, I am merging now!

@hacherix hacherix force-pushed the refactor-marche-inclusion branch from b713e75 to 206b20e Compare January 8, 2025 16:43
@hacherix hacherix merged commit 206b20e into main Jan 8, 2025
4 checks passed
@hacherix hacherix deleted the refactor-marche-inclusion branch January 8, 2025 16:49
@hacherix hacherix mentioned this pull request Jan 8, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HAEKADI HAEKADI HAEKADI approved these changes

Assignees

@hacherix hacherix

Labels
data pipelines refactoring/clean code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacherix @HAEKADI