Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR][SIRENE][STOCK]Introduce a data processor for Sirene stock #448

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

HAEKADI
Copy link
Contributor

@HAEKADI HAEKADI commented Jan 4, 2025

related to #405 and #447

The Sirene database, a critical data source, comprises two main components: stock (monthly and historical) and flux. To simplify the review process, each component will be addressed in a separate PR.

This PR focuses on the stock component and introduces the InseeStockProcessor. Specifically:

The stock DAG now downloads unité légale stock and historical files, as well as établissement historique files.
It removes the download of établissement stock files from Data.gouv, as these are no longer used. Instead, we rely on the geolocated files provided by Data.gouv.

@HAEKADI HAEKADI changed the base branch from main to refacto-insee January 4, 2025 22:10
@HAEKADI HAEKADI self-assigned this Jan 4, 2025
@HAEKADI HAEKADI changed the title Refacto insee stock [REFACTOR][SIRENE][STOCK]Introduce a data processor for Sirene stock Jan 4, 2025
@HAEKADI HAEKADI marked this pull request as ready for review January 5, 2025 19:34
@HAEKADI HAEKADI requested a review from hacherix as a code owner January 5, 2025 19:34
Copy link
Contributor

@hacherix hacherix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀💪

@HAEKADI HAEKADI force-pushed the refacto-insee-stock branch 2 times, most recently from 97235cf to 840c0f8 Compare January 6, 2025 12:51
Base automatically changed from refacto-insee to main January 6, 2025 13:36
@HAEKADI HAEKADI force-pushed the refacto-insee-stock branch from 840c0f8 to dcc4e77 Compare January 6, 2025 13:38
@HAEKADI HAEKADI merged commit 73d5e75 into main Jan 6, 2025
4 checks passed
@HAEKADI HAEKADI deleted the refacto-insee-stock branch January 6, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants