Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/select): match disabled placeholder color with label #29870

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(material/select): match disabled placeholder color with label #29870

merged 1 commit into from
Jan 13, 2025

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Oct 12, 2024

this commit ensures select with disabled placeholder matches the color with label

fixes #29807

@naaajii
fix(material/select): match disabled placeholder color with label
b125ebc 
this commit ensures select with disabled placeholder matches the color with label

fixes angular#29807
@naaajii naaajii requested a review from a team as a code owner October 12, 2024 19:26
@naaajii naaajii requested review from amysorto and wagnermaciel and removed request for a team October 12, 2024 19:26
@wagnermaciel wagnermaciel self-assigned this Jan 8, 2025
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Jan 10, 2025
@wagnermaciel
fix(material/select): remove color transition w/ no animations module
d4d6a21 
* Related to land PR angular#29870
@wagnermaciel wagnermaciel mentioned this pull request Jan 10, 2025
Merged
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Jan 10, 2025
@wagnermaciel
fix(material/select): remove color transition w/ no animations module
2e378a9 
* Related to PR angular#29870
wagnermaciel added a commit that referenced this pull request Jan 11, 2025
@wagnermaciel
fix(material/select): remove color transition w/ no animations module (…
d8d3987 
…#30304)

* Related to PR #29870
wagnermaciel added a commit that referenced this pull request Jan 11, 2025
@wagnermaciel
fix(material/select): remove color transition w/ no animations module (…
aae7924 
…#30304)

* Related to PR #29870

(cherry picked from commit d8d3987)
wagnermaciel added a commit that referenced this pull request Jan 11, 2025
@wagnermaciel
fix(material/select): remove color transition w/ no animations module (…
027c3ad 
…#30304)

* Related to PR #29870

(cherry picked from commit d8d3987)
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 13, 2025
@wagnermaciel wagnermaciel removed the request for review from amysorto January 13, 2025 17:25
@wagnermaciel wagnermaciel merged commit 306e437 into angular:main Jan 13, 2025
25 checks passed
wagnermaciel pushed a commit that referenced this pull request Jan 13, 2025
@naaajii @wagnermaciel
fix(material/select): match disabled placeholder color with label (#2…
e13a6b7 
…9870)

this commit ensures select with disabled placeholder matches the color with label

fixes #29807

(cherry picked from commit 306e437)
wagnermaciel pushed a commit that referenced this pull request Jan 13, 2025
@naaajii @wagnermaciel
fix(material/select): match disabled placeholder color with label (#2…
a3d9e4b 
…9870)

this commit ensures select with disabled placeholder matches the color with label

fixes #29807

(cherry picked from commit 306e437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatSelect): placeholder overrules disabled styling
2 participants
@naaajii @wagnermaciel