fix(@angular/build): only issue invalid i18n config error for duplicate subPaths with inlined locales
#29422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
This comment was marked as resolved.
This comment was marked as resolved.
…te `subPaths` with inlined locales The i18n configuration validation was incorrectly flagging errors for identical `subPaths` when both locales were not inlined within the same build. This was due to the validation not properly accounting for the inlining of locales. This commit fixes this issue by ensuring that the validation only checks for duplicate `subPaths` when the locales are inlined. Closes angular#29398
alan-agius4
force-pushed
the
i18n-subpath-validation
branch
from
9687e11 to
399eb32
Compare
clydin
approved these changes
Jan 21, 2025
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i18n configuration validation was incorrectly flagging errors for identical
subPathswhen both locales were not inlined within the same build. This was due to the validation not properly accounting for the inlining of locales.This commit fixes this issue by ensuring that the validation only checks for duplicate
subPathswhen the locales are inlined.Closes #29398