fix(@angular/build): do not mark Babel _defineProperty helper function as pure #29250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jsaguet
changed the title
jsaguet
force-pushed
the
fix/impure-define-property
branch
from
bac5d43 to
d9cbfcb
Compare
jsaguet
force-pushed
the
fix/impure-define-property
branch
from
d9cbfcb to
3bdc9c3
Compare
alan-agius4
reviewed
Jan 6, 2025
packages/angular/build/src/tools/babel/plugins/pure-toplevel-functions.ts
Outdated
Show resolved
Hide resolved
alan-agius4
added
the
target: patch
jsaguet
force-pushed
the
fix/impure-define-property
branch
from
3bdc9c3 to
46c1622
Compare
jsaguet
changed the title
alan-agius4
approved these changes
Jan 6, 2025
|
The changes were merged into the following branches: main, 19.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29145
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
_defineProperty is marked as pure and then tree shaken when targeting Safari < 15 or Chrome < 84 which breaks the application.
Issue Number: #29145
What is the new behavior?
_defineProperty is not marked as pure
Does this PR introduce a breaking change?
Other information