fix(@angular-devkit/build-angular) : fix incorrect budget calculation #29234
+64
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santoshyadavdev
force-pushed
the
fix-incorect-budget-warning
branch
from
656defa to
3394f77
Compare
alan-agius4
added
action: review
alan-agius4
reviewed
Jan 6, 2025
|
|
||
| const failures = Array.from(checkBudgets(budgets, stats)); | ||
|
|
||
| expect(failures.length).toBe(0); |
There was a problem hiding this comment.
Suggested change
| expect(failures.length).toBe(0); | |
| expect(failures).toHaveSize(0); |
alan-agius4
reviewed
Jan 6, 2025
| @@ -338,5 +336,38 @@ describe('bundle-calculator', () => { | |||
| message: jasmine.stringMatching('foo.ext exceeded maximum budget.'), | |||
| }); | |||
| }); | |||
|
|
|||
| it('yields exceeded individual file budget - 29040', () => { | |||
There was a problem hiding this comment.
This is not correct, as it does not yield exceeded
Suggested change
| it('yields exceeded individual file budget - 29040', () => { | |
| it('does not exceed the individual file budget limit', () => { |
alan-agius4
reviewed
Jan 6, 2025
| @@ -12,6 +12,8 @@ import { formatSize } from './format-bytes'; | |||
| // Re-export to avoid direct schema importing throughout code | |||
| export { type BudgetEntry, BudgetType }; | |||
|
|
|||
| export const kB = 1000; | |||
There was a problem hiding this comment.
Suggested change
| export const kB = 1000; | |
| export const BYTES_IN_KILOBYTE = 1000; |
alan-agius4
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks for this just a couple of NITs.
The commit scope should be @angular/build and not @angular-devkit/build-angular and please add a commit message body. https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
alan-agius4
added
action: cleanup
santoshyadavdev
force-pushed
the
fix-incorect-budget-warning
branch
from
3394f77 to
27710bb
Compare
santoshyadavdev
force-pushed
the
fix-incorect-budget-warning
branch
from
27710bb to
5f49618
Compare
This PR makes change to kB value which was incorrect earlier Fixes angular#29040
santoshyadavdev
force-pushed
the
fix-incorect-budget-warning
branch
from
5f49618 to
ae19e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29040
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #29040
What is the new behavior?
It uses kb value from packages/angular/build/src/utils/bundle-calculator.ts so there is no difference in value when running tests
Does this PR introduce a breaking change?
Other information