refactor(@schematics/angular): remove extraneous import from spec file #28981
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Nov 27, 2024
| @@ -8,7 +8,7 @@ describe('<%= classify(name) %><%= classify(type) %>', () => { | |||
|
|
|||
| beforeEach(async () => { | |||
| await TestBed.configureTestingModule({ | |||
| <%= standalone ? 'imports' : 'declarations' %>: [<%= classify(name) %><%= classify(type) %>] | |||
| <%= standalone ? '' : 'declarations' %>: [<%= classify(name) %><%= classify(type) %>] | |||
There was a problem hiding this comment.
This does not seem right, when standalone you need to remove the entire object liternal
There was a problem hiding this comment.
The configureTestingModule method requires an object literal even if it is empty.
There was a problem hiding this comment.
In the case, you need an remove the imports and it's value not just the key. As right now it's not valid.
alan-agius4
added
the
action: cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information