-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add secondary entrypoint schematic #28723
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Ship It!
Hi @alan-agius4 I saw that you added the discussion label. Any pointers what the discussion is about? I'm happy to join the discussion to see what we can improve or my point of view on things. |
@Jefiozie, since this is adding a new public API, we need to discuss this internally, and make sure that the team is on board with this. |
@alan-agius4 that does make sense, I will wait then and rebase this PR until you / the team comes back with feedback. |
acc6219
to
6d617b8
Compare
@alan-agius4 the PR is up-to-date with latest changes |
6d617b8
to
6392681
Compare
Hi @alan-agius4, happy new year! Did you found the time to talk about this schematic with the team? |
Hi @Jefiozie, |
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no easy way to generate a secondary entrypoint
Issue Number: #19070
What is the new behavior?
This PR adds the ability to generate a secondary entrypoint in a library project. It cannot be used without a library project.
Does this PR introduce a breaking change?
Other information
I've copied some helper utils from other schematics. I'm happy to make a other PR to add these to the utility parts with proper tests on it. Not updated the docs as this is I think in a other repo?
Pinging @SanderElias he mentioned there was nothing in the cli and encourage me to make this change 👍