Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency updates #1479

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix dependency updates #1479

merged 2 commits into from
Oct 3, 2024

Conversation

dturner
Copy link
Contributor

@dturner dturner commented Oct 3, 2024

Fixed #1478 by using the correct version variable for kotlinx-coroutines-test

Also changed the master project used for version updates from JetNews to Reply.

Why? JetNews doesn't use the kotlinx-serialization plugin so this was automatically removed when running versionCatalogUpdate gradle task. This meant that Reply would fail to build because it depends on this plugin.

@dturner dturner requested a review from a team as a code owner October 3, 2024 11:59
@dturner dturner requested a review from mlykotom October 3, 2024 11:59
@dturner
Copy link
Contributor Author

dturner commented Oct 3, 2024

For some reason an instrumented test for Jetchat is failing on the API 29 emulator. When I run locally all tests pass.

@dturner dturner merged commit d2e3e7b into main Oct 3, 2024
19 checks passed
@dturner dturner deleted the dt/fix-versions branch October 3, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Updating dependencies adds non-existent version for org.jetbrains.kotlinx:kotlinx-collections-immutable
3 participants