Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add driver for LTP8800-1A, LTP8800-4A and LTP8800-2 #2611

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add driver for LTP8800-1A, LTP8800-4A and LTP8800-2 #2611

wants to merge 3 commits into from
+214 −0

Conversation

cencarna
Copy link

@cencarna cencarna commented Oct 8, 2024

PR Description

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@cencarna cencarna force-pushed the dev/ltp8800 branch 2 times, most recently from 92d1a66 to 10f6b03 Compare October 8, 2024 06:15
nunojsa
nunojsa reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it goes my 2 cents. Go ahead and send this upstream :)

drivers/hwmon/pmbus/ltp8800.c Outdated Show resolved Hide resolved
drivers/hwmon/pmbus/ltp8800.c Show resolved Hide resolved
drivers/hwmon/pmbus/ltp8800.c Outdated Show resolved Hide resolved
Documentation/devicetree/bindings/hwmon/pmbus/adi,ltp8800.yaml Outdated Show resolved Hide resolved
@cencarna cencarna force-pushed the dev/ltp8800 branch 2 times, most recently from ef97830 to 925d8f8 Compare October 14, 2024 04:00
nunojsa
nunojsa reviewed Oct 14, 2024
View reviewed changes
MAINTAINERS Outdated Show resolved Hide resolved
@cencarna
dt-bindings: trivial-devices: add ltp8800
0746406 
Add Analog Devices LTP8800-1A, LTP8800-2, and LTP8800-4A DC/DC μModule
regulator.

Signed-off-by: Cedric Encarnacion <[email protected]>
@cencarna
hwmon: pmbus: add driver for ltp8800-1a, ltp8800-4a, and ltp8800-2
cc16bdc 
LTP8800-1A 150A DC/DC µModule Regulator with PMBus Interface
LTP8800-4A 200A DC/DC µModule Regulator with PMBus Interface
LTP8800-2 54V, 135A DC/DC μModule Regulator with PMBus Interface

Signed-off-by: Cedric Encarnacion <[email protected]>
@cencarna
hwmon: Kconfig.adi: imply ltp8800
133ed79 
Add entries for the LTP8800 driver.

Signed-off-by: Cedric Encarnacion <[email protected]>
@cencarna
Copy link
Author

v2:

  • Moved dts bindings to trivial-devices.yaml
  • Removed IS_ENABLED(REGULATOR) preprocessor. Regulator initialization moved to probe.
  • Removed __maybe_unused attribute.
  • housekeeping and build fixes

DT binding check always fails for some reason. Check complains this is due to title pattern which is already outside my changes.

nunojsa
nunojsa approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Please send this upstream and let's merge it once it's accepted there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunojsa nunojsa nunojsa approved these changes

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cencarna @nunojsa